Skip to content

fix nameof bug for operators - #10154

Merged
dsyme merged 2 commits into
dotnet:mainfrom
dsyme:no4
Sep 20, 2020
Merged

fix nameof bug for operators#10154
dsyme merged 2 commits into
dotnet:mainfrom
dsyme:no4

Conversation

@dsyme

Copy link
Copy Markdown
Contributor

We have a bug #10143

First we fix the tests so they actually run. This reveals two existing failures

Failed line 242
Failed line 246
let b = nameof(+)
Assert.AreEqual ("line " + string __LINE__) ("+",b)
let b3 = nameof(FSharp.Core.Operators.(+))
Assert.AreEqual ("line " + string __LINE__) ("+",b3)
Obviously this has never worked.

@dsymedsyme changed the title [WIP] fix nameof bug fix nameof bug for operatorsSep 19, 2020
@dsyme

Copy link
Copy Markdown
ContributorAuthor

@cartermp This is ready (once green)

We lost the change related to operators during the development of the PR, and the tests weren't active to prevent this

@dsyme
dsyme merged commit 1013a8d into dotnet:mainSep 20, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@dsyme@cartermp