Skip to content

Making several uses of Dictionary types be ConcurrentDictionary - #10308

Merged
dsyme merged 6 commits into
dotnet:mainfrom
TIHan:concurrent-structures
Oct 27, 2020
Merged

Making several uses of Dictionary types be ConcurrentDictionary#10308
dsyme merged 6 commits into
dotnet:mainfrom
TIHan:concurrent-structures

Conversation

@TIHan

@TIHanTIHan commented Oct 21, 2020

Copy link
Copy Markdown
Contributor

In order to make the compiler more concurrent safe, we needed to make several uses of Dictionary types be ConcurrentDictionary types. Remaining uses of Dictionary types have a comment noting why they are safe.

@TIHanTIHan mentioned this pull request Oct 21, 2020
Closed
11 tasks
saul
saul reviewed Oct 21, 2020
View reviewed changes
Comment threadsrc/absil/illib.fs
@TIHanTIHan closed this Oct 21, 2020
@TIHanTIHan reopened this Oct 21, 2020
@TIHanTIHan mentioned this pull request Oct 22, 2020
Merged
8 tasks
En3Tho
En3Tho reviewed Oct 24, 2020
View reviewed changes
Comment threadsrc/fsharp/TcGlobals.fs
cartermp
cartermp approved these changes Oct 24, 2020
View reviewed changes

@cartermpcartermp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

KevinRansom
KevinRansom approved these changes Oct 26, 2020
View reviewed changes

@KevinRansomKevinRansom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I do wonder, why a couple of tests changed the range, is it a quality of the dictionary type, or did something else subtle change.

Comment thread...tOrientedTypeDefinitions/ClassTypes/MemberDeclarations/E_ClashingInstanceStaticProperties.fs
Comment thread...e/ObjectOrientedTypeDefinitions/ClassTypes/MemberDeclarations/E_PropertySameNameDiffArity.fs
Comment threadtests/service/ProjectAnalysisTests.fs
("Property", ["member"; "prop"])]
let results = [ for x in classTypeDefn.MembersFunctionsAndValues -> x.LogicalName, attribsOfSymbol x ]
[(".ctor", ["member"; "ctor"]);
("get_Property", ["member"; "getter"]);

@KevinRansomKevinRansomOct 26, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elsewhere these are indented.

dsyme
dsyme reviewed Oct 27, 2020
View reviewed changes
Comment threadsrc/fsharp/InfoReader.fs
dsyme
dsyme requested changes Oct 27, 2020
View reviewed changes

@dsymedsyme left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes requested

@KevinRansomKevinRansom mentioned this pull request Oct 27, 2020
Open
@KevinRansom

KevinRansom commented Oct 27, 2020

Copy link
Copy Markdown
Contributor

I added this issue: #10342 to manage the possible dictionary storage order dependency.

dsyme
dsyme approved these changes Oct 27, 2020
View reviewed changes

@dsymedsyme left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked again and no changes are needed

@dsyme
dsyme merged commit 381b22a into dotnet:mainOct 27, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsymedsymedsyme approved these changes
+4 more reviewers
@saulsaulsaul left review comments
@KevinRansomKevinRansomKevinRansom approved these changes
@En3ThoEn3ThoEn3Tho left review comments
@cartermpcartermpcartermp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@TIHan@KevinRansom@saul@cartermp@dsyme@En3Tho