Skip to content

Prepare to ship FCS 39.0.0-preview - #10584

Merged
KevinRansom merged 5 commits into
dotnet:mainfrom
KevinRansom:resetFSharpCorePsckageVersion
Dec 7, 2020
Merged

Prepare to ship FCS 39.0.0-preview#10584
KevinRansom merged 5 commits into
dotnet:mainfrom
KevinRansom:resetFSharpCorePsckageVersion

Conversation

@KevinRansom

@KevinRansomKevinRansom commented Dec 2, 2020

Copy link
Copy Markdown
Contributor

Prepare to ship fcs 39.0.0-preview

Reset FSharp.Core package version back to 5.0.0 because thats what shipped and set fcs version to 38.0.1

@baronfel

Copy link
Copy Markdown
Member

I think the version number required us going to have to be 39, because there are a number of public surface area changes already in main from the 38 release.

I know that the reactor thread changes are in there, for example.

@baronfel

Copy link
Copy Markdown
Member

Also, for this release could the MSBuild dependencies get added to the nuspec? It's a pretty prevalent gotcha that's hit several other consumers (including sharplab and xunit).

If that dependency gets extracted later then it can just be removed from the nuspec.

@KevinRansom

Copy link
Copy Markdown
ContributorAuthor

@baronfel see: #10588

@KevinRansomKevinRansom changed the title Prepare to ship FCS 38.0.1Prepare to ship FCS 39.0.0-previewDec 2, 2020
@KevinRansom
KevinRansomforce-pushed the resetFSharpCorePsckageVersion branch from 35a597b to 46c464fCompareDecember 2, 2020 22:41
Comment threadeng/Versions.props Outdated
@KevinRansom

Copy link
Copy Markdown
ContributorAuthor

@cartermp / @brettfo -- any issues or can we merge it?

Comment threadeng/Versions.props Outdated
@KevinRansom
KevinRansom merged commit 43efdf2 into dotnet:mainDec 7, 2020
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
* Prepare to ship fcs 39.0.0-preview-
* feedback
* Update Versions.props
Oops bad merge
@KevinRansom
KevinRansom deleted the resetFSharpCorePsckageVersion branch January 21, 2022 09:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@KevinRansom@baronfel@brettfo@cartermp