Verbatim string ast

[nojaf]

An attempt to keep track in the AST whether a string is verbatim and/or triple quote or not.
Fixes#10209.

Many thanks again @baronfel for doing some pair programming on this.

[cartermp]

Hmm, saw the same test. We regressed opening static classes somehow. cc @KevinRansom

[cartermp]

errr, default interface tests

[nojaf]

This is ready for review.
Any ideas if the failing test

 Failed C# diamond complex hierarchical interfaces then combined in one C# interface and then implemented - Runs - 3 [528 ms]
Error Message:
'CSharpIFinalCombinedTest-Method1-CSharpIFinalCombinedTest-Method2' = ''
Expected string length 65 but was 0. Strings differ at index 0.
Expected: "CSharpIFinalCombinedTest-Method1-CSharpIFinalCombinedTest-Met..."
But was: <string.Empty>
-----------^
Stack Trace:
at <StartupCode$FSharp-Test-Utilities>.$CompilerAssert.ExecutionHasOutput@499.Invoke(String output) in D:\a\1\s\tests\FSharp.Test.Utilities\CompilerAssert.fs:line 499
at <StartupCode$FSharp-Test-Utilities>.$CompilerAssert.Execute@487-1.Invoke(Tuple`2 tupledArg) in D:\a\1\s\tests\FSharp.Test.Utilities\CompilerAssert.fs:line 494
at FSharp.Test.Utilities.CompilerAssert.compileCompilation[a](Boolean ignoreWarnings, Compilation cmpl, FSharpFunc`2 f) in D:\a\1\s\tests\FSharp.Test.Utilities\CompilerAssert.fs:line 391
at <StartupCode$FSharp-Test-Utilities>.$CompilerAssert.Execute@486.Invoke(Unit unitVar0) in D:\a\1\s\tests\FSharp.Test.Utilities\CompilerAssert.fs:line 487
at FSharp.Test.Utilities.CompilerAssert.Execute(Compilation cmpl, FSharpOption`1 ignoreWarnings, FSharpOption`1 beforeExecute, FSharpOption`1 newProcess, FSharpOption`1 onOutput) in D:\a\1\s\tests\FSharp.Test.Utilities\CompilerAssert.fs:line 485
at FSharp.Test.Utilities.CompilerAssert.ExecutionHasOutput(Compilation cmpl, String expectedOutput) in D:\a\1\s\tests\FSharp.Test.Utilities\CompilerAssert.fs:line 499
at FSharp.Compiler.UnitTests.DefaultInterfaceMemberConsumptionTests.C# diamond complex hierarchical interfaces then combined in one C# interface and then implemented - Runs - 3() in D:\a\1\s\tests\fsharp\Compiler\Language\DefaultInterfaceMemberTests.fs:line 3198

is related to my changes?

[cartermp]

@nojaf No, your changes are fine, but something is wrong with your merge of main into this branch, since it's not picking up a fix to our test helpers that was made recently. Would it be possible to just rebase atop latest main?

[nojaf]

@cartermp I think the rebase is ok now. Getting different problems now.
Let me know if there is anything I can do.

[cartermp]

Are you against the very latest main? The issues now are compile-time because of recent FCS changes:

error FS0001: This expression was expected to have type� 'LayoutTag' �but here has type� 'string' 

Either that or we have our internal build broken? Will investigate

[baronfel]

Oh, looks like there are changes required to the vsintegration as a result of this. We were only looking at FCS-level changes, which explains that. @nojaf you'll need to update the vsintegration in FSharp.Editor as well. My bad, man.

[cartermp]

No, it's on our end. @dsyme some of your changes were merged without updating VS, leading to compile errors.

[cartermp]

This fixes it: #10783

[nojaf]

Great, thanks for the quick response 👍.

[KevinRansom]

APIs with bool->bool->bool are real easy to get wrong, can you simplify, use enums, or a flag enum or something please.

Otherwise this looks great.
Thanks

[cartermp]

Thanks! I think this is great.

[nojaf]

I also extended SynExpr.InterpolatedString to check if there were triple quotes present.

[TIHan]

This looks good. I had one comment regarding the use of bools for the token definitions.

outdated