Uh oh!
There was an error while loading. Please reload this page.
Set: Optimize away isinst check - #10860
Conversation
Store height in leaves. Compared to the old discussion, when Left/Right were proposed to be stored in a universal node, this adds 4 bytes to leaves or 2 bytes per item on average (vs 16/8).
`Match` produces `sub 1` and `switch` instruction. Here, for any non-trivial count, nodes are more frequent than leaves on the path, so branch prediction should be beneficial.
cartermp
commented
Jan 12, 2021
@buybackoff No worries, we'll figure out the right merge strategy. I believe that because the changes are the same, it shouldn't matter if we take them independently. |
cartermp
left a comment
There was a problem hiding this comment.
Changes look good for set too (I mean, they're the same, but hey, looks good!)
cartermp
commented
Jan 12, 2021
@dsyme if you could take a look here as well that would be great. @buybackoff just FYI - in case this does take time to merge - we have a policy of two approvals required for PRs. We relax that a bit when the changes are straightforward and/or tiny, but this will require two sign-offs to proceed since it affects such a core set of data structures. |
KevinRansom
left a comment
There was a problem hiding this comment.
Looks good. Thanks for this.
Same as #10845
If OK, this PR includes the Map changes. The Map one could be closed and this merged, or will rebase.