Skip to content

use path separator instead of hardcoded semicolon - #11730

Merged
vzarytovskii merged 2 commits into
dotnet:mainfrom
baronfel:depmanager-path-handling
Jun 28, 2021
Merged

use path separator instead of hardcoded semicolon#11730
vzarytovskii merged 2 commits into
dotnet:mainfrom
baronfel:depmanager-path-handling

Conversation

@baronfel

Copy link
Copy Markdown
Member

This should fix#11729, but we'll see what CI has to say about it.

Comment threadsrc/fsharp/DependencyManager/NativeDllResolveHandler.fs Outdated
@baronfel
baronfelforce-pushed the depmanager-path-handling branch from dca8ebe to 93c9c68CompareJune 25, 2021 19:03
@brettfo
brettfo enabled auto-merge (squash) June 25, 2021 19:05
auto-merge was automatically disabled June 25, 2021 19:23

Head branch was pushed to by a user without write access

@baronfel
baronfelforce-pushed the depmanager-path-handling branch from 93c9c68 to 176aabbCompareJune 25, 2021 19:23
@baronfel

Copy link
Copy Markdown
MemberAuthor

System.IO.Path.PathSeparator is a char, pushed up a stringification of it to fix that. The joys of editorless-changes.

@baronfel
baronfelforce-pushed the depmanager-path-handling branch from 176aabb to 8abfea1CompareJune 28, 2021 13:49
Comment threadsrc/fsharp/DependencyManager/NativeDllResolveHandler.fs Outdated
Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>
@vzarytovskii
vzarytovskii merged commit 784c7ad into dotnet:mainJun 28, 2021
@dsyme

Copy link
Copy Markdown
Contributor

Thank you, I didn't know about System.IO.Path.PathSeparator

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FSI nuget reference (#r) breaks the process' PATH environment variable on Linux

4 participants

@baronfel@dsyme@brettfo@vzarytovskii