Skip to content

second part of #11755 - #11763

Merged
dsyme merged 17 commits into
dotnet:mainfrom
dsyme:f78
Aug 12, 2021
Merged

second part of #11755#11763
dsyme merged 17 commits into
dotnet:mainfrom
dsyme:f78

Conversation

@dsyme

Copy link
Copy Markdown
Contributor

#11755 contained two fixes - the second noticed when I ramped up the testing for debug mode code.

However we want to take the minimal fix for the regression, and the second bug fix is not complete

So this is tracking the second bug fix

@dsymedsyme closed this Aug 11, 2021
@dsymedsyme reopened this Aug 11, 2021
@dsyme

Copy link
Copy Markdown
ContributorAuthor

Random unrelated test failure

2021-08-12T11:45:58.1366610Z [xUnit.net 00:01:37.43] FSharp.Core.UnitTests.Control.AsyncModule.AwaitWaitHandle.Timeout [FAIL]
2021-08-12T11:45:58.7229320Z Failed FSharp.Core.UnitTests.Control.AsyncModule.AwaitWaitHandle.Timeout [1 s]
2021-08-12T11:45:58.7233710Z Error Message:
2021-08-12T11:45:58.7234660Z Expected faster timeout than 1505 ms
2021-08-12T11:45:58.7235730Z Expected: True
2021-08-12T11:45:58.7236740Z Actual: False
2021-08-12T11:45:58.7237720Z Stack Trace:
2021-08-12T11:45:58.7238960Z at FSharp.Core.UnitTests.Control.AsyncModule.AwaitWaitHandle.Timeout() in /Users/runner/work/1/s/tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/AsyncModule.fs:line 232

@dsyme
dsyme merged commit 96e1782 into dotnet:mainAug 12, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dsyme@vzarytovskii@TIHan@KevinRansom