Uh oh!
There was an error while loading. Please reload this page.
Correct body SynExpr of parsedData of Lambda when wildcards are involved. - #11781
Merged
Conversation
nojaf
commented
Jul 3, 2021
Uh oh!
There was an error while loading. Please reload this page.
dsyme
commented
Jul 5, 2021
Contributor
This looks good. Some tests need updating, e.g. it's a good thing that the results no longer contain 2021-07-03T14:32:29.6342157Z Failed Test Project23 property [77 ms]2021-07-03T14:32:29.6342682Z Error Message:2021-07-03T14:32:29.6343239Z Expected:[(".ctor",["member";"ctor"]);("get_StaticProperty",["member";"getter"]);2021-07-03T14:32:29.6343815Z ("get_Property",["member";"getter"]);("x",[]);2021-07-03T14:32:29.6344302Z ("get_Zero",["member";"extmem";"getter"]);2021-07-03T14:32:29.6344784Z ("get_Value",["member";"extmem";"getter"]);("x",[]);2021-07-03T14:32:29.6345476Z ("Value",["member";"prop";"extmem"]);2021-07-03T14:32:29.6346144Z ("set_Value",["member";"extmem";"setter"]);("x",[]);2021-07-03T14:32:29.6346935Z ("_arg1",["compgen"]);("Value",["member";"prop";"extmem"])]2021-07-03T14:32:29.6347728Z Actual:[(".ctor",["member";"ctor"]);("get_StaticProperty",["member";"getter"]);2021-07-03T14:32:29.6348396Z ("get_Property",["member";"getter"]);("x",[]);2021-07-03T14:32:29.6348978Z ("get_Zero",["member";"extmem";"getter"]);2021-07-03T14:32:29.6349589Z ("get_Value",["member";"extmem";"getter"]);("x",[]);2021-07-03T14:32:29.6350138Z ("Value",["member";"prop";"extmem"]);2021-07-03T14:32:29.6350696Z ("set_Value",["member";"extmem";"setter"]);("x",[]);2021-07-03T14:32:29.6351231Z ("Value",["member";"prop";"extmem"])]2021-07-03T14:32:29.6351970Z Expected andactual are both <Microsoft.FSharp.Collections.FSharpList`1[System.Tuple`2[System.String,Microsoft.FSharp.Collections.FSharpList`1[System.String]]]>2021-07-03T14:32:29.6352850Z These four code generation tests also need updating: On windows you can update them using and waiting until the updates to the BSL are done. |
nojaf
commented
Jul 5, 2021
ContributorAuthor
Hi Don, thanks for this feedback. Running
|
dsyme
commented
Jul 6, 2021
Contributor
Are you running from an elevated/admin command prompt? |
nojaf
commented
Jul 6, 2021
ContributorAuthor
Yes, more of the same |
dsyme
commented
Jul 6, 2021
Contributor
@nojaf How strange. I'll check on my machine, this may be a recent thing |
Contributor
@nojaf I seem to be able to run I've pushed the updates to the baselines to your branch |
nojaf
commented
Jul 6, 2021
ContributorAuthor
Many thanks Don! |
nojaf
commented
Jul 9, 2021
ContributorAuthor
Hey @vzarytovskii could I get a review please? |
dsyme
approved these changes
Jul 9, 2021
dsyme
commented
Jul 9, 2021
Contributor
Thanks @nojaf ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to fsprojects/fantomas#1806.
In Fantomas, we want to use
parsedDataof SynExpr.Lambda to print out the body expression of the lambda.This is currently wrapped in match expressions when wildcards are involved.
This PR tries to resolve this.