Cleanup collection functions

[forki]

• Optimizing namespaces
• inlining LanguagePrimitives.ErrorStrings.InputMustBeNonNegativeString
• using Array.empty

[dsyme]

Fakey AppVeyor results upoading:

[00:57:57] Resolve-Path : Cannot find path [00:57:57] 'C:\projects\visualfsharp-3dtit\tests\CoreUnit_coreclr_Xml.xml' because it [00:57:57] does not exist.
[00:57:57] At C:\projects\visualfsharp-3dtit\tests\Upload-Results.ps1:17 char:23
[00:57:57] + $wc.UploadFile($url, (Resolve-Path $path))
[00:57:57] + ~~~~~~~~~~~~~~~~~~
[00:57:57] + CategoryInfo : ObjectNotFound: (C:\projects\vis...coreclr_Xml.x [00:57:57] ml:String) [Resolve-Path], ItemNotFoundException
[00:57:57] + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.Resol [00:57:57] vePathCommand
[00:57:57] 

[forki]

That's unrelated, right?

[dsyme]

@forki Yes, unrelated. It's been seen before, don't understand why it happens.

[dsyme]

I think we don't want to do this for non-inlined functions. There is an outstanding bug where those "inlined" strings are non-localized (e.g. in Italian). So where possible we use the SR.GetString call

[forki]

really? is this bug tracked here?

[PatrickMcDonald]

@forki It's #159

[forki]

thanks. let's try to fix that one then ;-)

[dsyme]

Actually IIRC it's hard to fix - amking those "inlined" values into functions involves adding surface area to FSharp.Core. There was some reason we pulled out of fixing it though I'm not sure why.

Is there any particular reason you want to use the direct string?

[forki]

I guess I can revert that.

On Jul 22, 2016 11:39 AM, "Don Syme" notifications@github.com wrote:

In src/fsharp/FSharp.Core/array.fs
#1347 (comment)
:

@@ -120,8 +121,8 @@ namespace Microsoft.FSharp.Collections

 [<CompiledName("Replicate")>]
let replicate count x =

•  if count < 0 then invalidArg "count" (SR.GetString(SR.inputMustBeNonNegative))
  

•  let arr = (Microsoft.FSharp.Primitives.Basics.Array.zeroCreateUnchecked count : 'T array)
  

•  if count < 0 then invalidArg "count" LanguagePrimitives.ErrorStrings.InputMustBeNonNegativeString
  

Actually IIRC it's hard to fix - amking those "inlined" values into
functions involves adding surface area to FSharp.Core. There was some
reason we pulled out of fixing it though I'm not sure why.

Is there any particular reason you want to use the direct string?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/visualfsharp/pull/1347/files/057f9aa43438c2f76a1505ddb288de1887437824#r71852825,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNEMFoQrpWeBPeW2UZ7Ti1HLP2Z3Tks5qYI_ggaJpZM4JLdjM
.

[forki]

ok reverted that part. ready for review.

[KevinRansom]

@dotnet-bot test this please

[KevinRansom]

@forki --

When I fixed the merge errors on this one I get this build error:

 "d:\microsoft\visualfsharp\build-everything.proj" (default target) (1) ->
"d:\microsoft\visualfsharp\src\fsharp-library-build.proj" (Build target) (2) ->
"d:\microsoft\visualfsharp\src\fsharp\FSharp.Core\FSharp.Core.fsproj" (Build target) (3) ->
(CoreCompile target) ->
d:\microsoft\visualfsharp\src\fsharp\FSharp.Core\array.fsi(469,20): error FS1113: The value 'init' was marked inline but its implementation makes use of an internal or private function which is not sufficiently acce
ssible [d:\microsoft\visualfsharp\src\fsharp\FSharp.Core\FSharp.Core.fsproj]
0 Warning(s)
1 Error(s)

I like all of the cleanup in this PR, it all looks good except for this one thing.

[forki]

Let me rebase this.

[forki]

ok should work now

[dsyme]

@forki Thanks for this!