Skip to content

try to reproduce async choice error revealed in #1378 - #1379

Merged
dsyme merged 4 commits into
dotnet:masterfrom
forki:asyncchoice
Aug 1, 2016
Merged

try to reproduce async choice error revealed in #1378#1379
dsyme merged 4 commits into
dotnet:masterfrom
forki:asyncchoice

Conversation

@forki

@forkiforki commented Jul 25, 2016

Copy link
Copy Markdown
Contributor

/cc @eiriktsarpalis
I run the sample A LOT and it seems to be failing

@smoothdeveloper

Copy link
Copy Markdown
Contributor
Failed : FSharp.Core.Unittests.FSharp_Core.Microsoft_FSharp_Control.AsyncModule.Async.Choice repro
Expected: less than or equal to 4
But was: 5
at FSharp.Core.Unittests.FSharp_Core.Microsoft_FSharp_Control.AsyncModule.Async.Choice repro() in C:\projects\visualfsharp-3dtit\src\fsharp\FSharp.Core.Unittests\FSharp.Core\Microsoft.FSharp.Control\AsyncModule.fs:line 438

@eiriktsarpalis

Copy link
Copy Markdown
Member

@forki

Copy link
Copy Markdown
ContributorAuthor

@KevinRansom this is not compiling on coreclr!? but I have the code under

#if !(FSHARP_CORE_PORTABLE || FSHARP_CORE_NETCORE_PORTABLE)

any ideas why it's still in the coreclr build?

@forki

Copy link
Copy Markdown
ContributorAuthor
Build timed out (after 120 minutes). Marking the build as aborted.

It looks like this actually fixed the test. So let me remove the brute-force test and keep the ThreadPool.SetMinThreads(100,100) for the property-based test. This should remove a bit of flakyness.

@forkiforki changed the title WIP: try to reproduce async choice error revealed in #1378try to reproduce async choice error revealed in #1378Jul 26, 2016
@forki

Copy link
Copy Markdown
ContributorAuthor

ok I think this is ready to go in

@dsyme
dsyme merged commit 17c786b into dotnet:masterAug 1, 2016
@libozliboz mentioned this pull request Aug 5, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@forki@smoothdeveloper@eiriktsarpalis@dsyme@msftclas