Verify ship status by KevinRansom · Pull Request #13793 · dotnet/fsharp

KevinRansom · 2022-08-27T01:20:12Z

Now that the SDK build process automatically publishes FSharp.Core and FSharp.Compiler.Service, we need a mechanism to remind us to rev version numbers.

Here it is.

It uses an exact match packagereference to verify that the package id we think we are building hasn't been published yet.
It will run automatically on internal signed builds
not run on PR's except this one, cos I'm verifying that it works correctly in the ci environment.

It should be noted that during a build, we are not connected to nuget.org by design ... it is part of our mechanism to ensure that we don't have supply chain issues accessing public dlls.

The actual projects that we build are disconnected from the general build and set the packageroot and httpcache to a discardable location, with a random name. So ... that takes care of supply chain.

To see what it does type build -c release -verifypackageshipstatus
And observe the output this is the failing case:

KevinRansom · 2022-08-27T01:21:42Z

Hey @brettfo , I would really appreciate, you running your eyes over this.

Thanks mate

vzarytovskii · 2022-08-29T12:50:55Z

We should probably have a separate CI leg which is running on the latest release branch, @KevinRansom do you want me to take care of it? I have an idea how to deal with it.

brettfo · 2022-08-29T17:39:34Z

+ <PropertyGroup>
+ <TargetFramework>net7.0</TargetFramework>
+ <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
+ <CachePath>$(MSBuildProjectDirectory)\..\..\artifacts\tmp\$([System.Guid]::NewGuid())</CachePath>


These few lines shouldn't need to be here; the auto-import of Directory.Build.props should handle it and reduce the duplication.

I'm not a fan of putting project stuff in the Directory.Build.props and targets, it makes project files so hard to reason about.

brettfo · 2022-08-29T17:40:07Z

@@ -0,0 +1,23 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+ <Import Project="$(MSBuildProjectDirectory)\..\..\eng\Versions.props" />


Might as well bump this import up to the Directory.Build.props level.

brettfo · 2022-08-29T17:41:38Z

 }

+ $verifypackageshipstatusFailed = $false
+ if ($verifypackageshipstatus) {


Related to Vlad's comment, pull this out into a separate file, something like eng/VerifyPackageShipStatus.ps1, that way it'll be easier to add as a separate build step and/or run locally.

There is a build.ps1 switch for running this:
https://github.com/dotnet/fsharp/pull/13793/files#diff-9841a029538b042b58ee9aabac3d4cd9c725a2495d81d188d23f6ad617f2a262R66
https://github.com/dotnet/fsharp/pull/13793/files#diff-9841a029538b042b58ee9aabac3d4cd9c725a2495d81d188d23f6ad617f2a262R121
So build -verifypackageshipstatus will make it easy to run.

KevinRansom · 2022-08-29T22:44:44Z

@vzarytovskii , we talked about this earlier, we agreed to run this when we merge into release branches. You can please take care of the yaml update for that :-)

* Revert tools.sh edit (#13796) * Revert tools.sh edit * Add binlog to build.sh for proto stuff * Verify ship status (#13793) * Verify ship status * -verifypackageshipstatus in the right place * more * Update Versions.props * Update azure-pipelines.yml * reactivate test - Help is displayed correctly (#13792) * tcconfig/tcconfigbuilder * add --bufferwidth * fantomas * oops Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com> Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>

KevinRansom · 2022-08-27T01:20:12Z

Now that the SDK build process automatically publishes FSharp.Core and FSharp.Compiler.Service, we need a mechanism to remind us to rev version numbers.

Here it is.

It uses an exact match packagereference to verify that the package id we think we are building hasn't been published yet.
It will run automatically on internal signed builds
not run on PR's except this one, cos I'm verifying that it works correctly in the ci environment.

It should be noted that during a build, we are not connected to nuget.org by design ... it is part of our mechanism to ensure that we don't have supply chain issues accessing public dlls.

The actual projects that we build are disconnected from the general build and set the packageroot and httpcache to a discardable location, with a random name. So ... that takes care of supply chain.

To see what it does type build -c release -verifypackageshipstatus
And observe the output this is the failing case:

KevinRansom · 2022-08-27T01:21:42Z

Hey @brettfo , I would really appreciate, you running your eyes over this.

Thanks mate

vzarytovskii · 2022-08-29T12:50:55Z

We should probably have a separate CI leg which is running on the latest release branch, @KevinRansom do you want me to take care of it? I have an idea how to deal with it.

brettfo · 2022-08-29T17:39:34Z

+ <PropertyGroup>
+ <TargetFramework>net7.0</TargetFramework>
+ <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
+ <CachePath>$(MSBuildProjectDirectory)\..\..\artifacts\tmp\$([System.Guid]::NewGuid())</CachePath>


These few lines shouldn't need to be here; the auto-import of Directory.Build.props should handle it and reduce the duplication.

I'm not a fan of putting project stuff in the Directory.Build.props and targets, it makes project files so hard to reason about.

brettfo · 2022-08-29T17:40:07Z

@@ -0,0 +1,23 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+ <Import Project="$(MSBuildProjectDirectory)\..\..\eng\Versions.props" />


Might as well bump this import up to the Directory.Build.props level.

brettfo · 2022-08-29T17:41:38Z

 }

+ $verifypackageshipstatusFailed = $false
+ if ($verifypackageshipstatus) {


Related to Vlad's comment, pull this out into a separate file, something like eng/VerifyPackageShipStatus.ps1, that way it'll be easier to add as a separate build step and/or run locally.

There is a build.ps1 switch for running this:
https://github.com/dotnet/fsharp/pull/13793/files#diff-9841a029538b042b58ee9aabac3d4cd9c725a2495d81d188d23f6ad617f2a262R66
https://github.com/dotnet/fsharp/pull/13793/files#diff-9841a029538b042b58ee9aabac3d4cd9c725a2495d81d188d23f6ad617f2a262R121
So build -verifypackageshipstatus will make it easy to run.

KevinRansom · 2022-08-29T22:44:44Z

@vzarytovskii , we talked about this earlier, we agreed to run this when we merge into release branches. You can please take care of the yaml update for that :-)

* Revert tools.sh edit (#13796) * Revert tools.sh edit * Add binlog to build.sh for proto stuff * Verify ship status (#13793) * Verify ship status * -verifypackageshipstatus in the right place * more * Update Versions.props * Update azure-pipelines.yml * reactivate test - Help is displayed correctly (#13792) * tcconfig/tcconfigbuilder * add --bufferwidth * fantomas * oops Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com> Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>

KevinRansom · 2022-08-27T01:20:12Z

Now that the SDK build process automatically publishes FSharp.Core and FSharp.Compiler.Service, we need a mechanism to remind us to rev version numbers.

Here it is.

It uses an exact match packagereference to verify that the package id we think we are building hasn't been published yet.
It will run automatically on internal signed builds
not run on PR's except this one, cos I'm verifying that it works correctly in the ci environment.

It should be noted that during a build, we are not connected to nuget.org by design ... it is part of our mechanism to ensure that we don't have supply chain issues accessing public dlls.

The actual projects that we build are disconnected from the general build and set the packageroot and httpcache to a discardable location, with a random name. So ... that takes care of supply chain.

To see what it does type build -c release -verifypackageshipstatus
And observe the output this is the failing case:

KevinRansom · 2022-08-27T01:21:42Z

Hey @brettfo , I would really appreciate, you running your eyes over this.

Thanks mate

vzarytovskii · 2022-08-29T12:50:55Z

We should probably have a separate CI leg which is running on the latest release branch, @KevinRansom do you want me to take care of it? I have an idea how to deal with it.

brettfo · 2022-08-29T17:39:34Z

+ <PropertyGroup>
+ <TargetFramework>net7.0</TargetFramework>
+ <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
+ <CachePath>$(MSBuildProjectDirectory)\..\..\artifacts\tmp\$([System.Guid]::NewGuid())</CachePath>


These few lines shouldn't need to be here; the auto-import of Directory.Build.props should handle it and reduce the duplication.

I'm not a fan of putting project stuff in the Directory.Build.props and targets, it makes project files so hard to reason about.

brettfo · 2022-08-29T17:40:07Z

@@ -0,0 +1,23 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+ <Import Project="$(MSBuildProjectDirectory)\..\..\eng\Versions.props" />


Might as well bump this import up to the Directory.Build.props level.

brettfo · 2022-08-29T17:41:38Z

 }

+ $verifypackageshipstatusFailed = $false
+ if ($verifypackageshipstatus) {


Related to Vlad's comment, pull this out into a separate file, something like eng/VerifyPackageShipStatus.ps1, that way it'll be easier to add as a separate build step and/or run locally.

There is a build.ps1 switch for running this:
https://github.com/dotnet/fsharp/pull/13793/files#diff-9841a029538b042b58ee9aabac3d4cd9c725a2495d81d188d23f6ad617f2a262R66
https://github.com/dotnet/fsharp/pull/13793/files#diff-9841a029538b042b58ee9aabac3d4cd9c725a2495d81d188d23f6ad617f2a262R121
So build -verifypackageshipstatus will make it easy to run.

KevinRansom · 2022-08-29T22:44:44Z

@vzarytovskii , we talked about this earlier, we agreed to run this when we merge into release branches. You can please take care of the yaml update for that :-)

* Revert tools.sh edit (#13796) * Revert tools.sh edit * Add binlog to build.sh for proto stuff * Verify ship status (#13793) * Verify ship status * -verifypackageshipstatus in the right place * more * Update Versions.props * Update azure-pipelines.yml * reactivate test - Help is displayed correctly (#13792) * tcconfig/tcconfigbuilder * add --bufferwidth * fantomas * oops Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com> Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>

KevinRansom · 2022-08-27T01:20:12Z

Now that the SDK build process automatically publishes FSharp.Core and FSharp.Compiler.Service, we need a mechanism to remind us to rev version numbers.

Here it is.

It uses an exact match packagereference to verify that the package id we think we are building hasn't been published yet.
It will run automatically on internal signed builds
not run on PR's except this one, cos I'm verifying that it works correctly in the ci environment.

It should be noted that during a build, we are not connected to nuget.org by design ... it is part of our mechanism to ensure that we don't have supply chain issues accessing public dlls.

The actual projects that we build are disconnected from the general build and set the packageroot and httpcache to a discardable location, with a random name. So ... that takes care of supply chain.

To see what it does type build -c release -verifypackageshipstatus
And observe the output this is the failing case:

KevinRansom · 2022-08-27T01:21:42Z

Hey @brettfo , I would really appreciate, you running your eyes over this.

Thanks mate

vzarytovskii · 2022-08-29T12:50:55Z

We should probably have a separate CI leg which is running on the latest release branch, @KevinRansom do you want me to take care of it? I have an idea how to deal with it.

brettfo · 2022-08-29T17:39:34Z

+ <PropertyGroup>
+ <TargetFramework>net7.0</TargetFramework>
+ <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
+ <CachePath>$(MSBuildProjectDirectory)\..\..\artifacts\tmp\$([System.Guid]::NewGuid())</CachePath>


These few lines shouldn't need to be here; the auto-import of Directory.Build.props should handle it and reduce the duplication.

I'm not a fan of putting project stuff in the Directory.Build.props and targets, it makes project files so hard to reason about.

brettfo · 2022-08-29T17:40:07Z

@@ -0,0 +1,23 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+ <Import Project="$(MSBuildProjectDirectory)\..\..\eng\Versions.props" />


Might as well bump this import up to the Directory.Build.props level.

brettfo · 2022-08-29T17:41:38Z

 }

+ $verifypackageshipstatusFailed = $false
+ if ($verifypackageshipstatus) {


Related to Vlad's comment, pull this out into a separate file, something like eng/VerifyPackageShipStatus.ps1, that way it'll be easier to add as a separate build step and/or run locally.

There is a build.ps1 switch for running this:
https://github.com/dotnet/fsharp/pull/13793/files#diff-9841a029538b042b58ee9aabac3d4cd9c725a2495d81d188d23f6ad617f2a262R66
https://github.com/dotnet/fsharp/pull/13793/files#diff-9841a029538b042b58ee9aabac3d4cd9c725a2495d81d188d23f6ad617f2a262R121
So build -verifypackageshipstatus will make it easy to run.

KevinRansom · 2022-08-29T22:44:44Z

@vzarytovskii , we talked about this earlier, we agreed to run this when we merge into release branches. You can please take care of the yaml update for that :-)

* Revert tools.sh edit (#13796) * Revert tools.sh edit * Add binlog to build.sh for proto stuff * Verify ship status (#13793) * Verify ship status * -verifypackageshipstatus in the right place * more * Update Versions.props * Update azure-pipelines.yml * reactivate test - Help is displayed correctly (#13792) * tcconfig/tcconfigbuilder * add --bufferwidth * fantomas * oops Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com> Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>

KevinRansom · 2022-08-27T01:20:12Z

Now that the SDK build process automatically publishes FSharp.Core and FSharp.Compiler.Service, we need a mechanism to remind us to rev version numbers.

Here it is.

It uses an exact match packagereference to verify that the package id we think we are building hasn't been published yet.
It will run automatically on internal signed builds
not run on PR's except this one, cos I'm verifying that it works correctly in the ci environment.

It should be noted that during a build, we are not connected to nuget.org by design ... it is part of our mechanism to ensure that we don't have supply chain issues accessing public dlls.

The actual projects that we build are disconnected from the general build and set the packageroot and httpcache to a discardable location, with a random name. So ... that takes care of supply chain.

To see what it does type build -c release -verifypackageshipstatus
And observe the output this is the failing case:

KevinRansom · 2022-08-27T01:21:42Z

Hey @brettfo , I would really appreciate, you running your eyes over this.

Thanks mate

vzarytovskii · 2022-08-29T12:50:55Z

We should probably have a separate CI leg which is running on the latest release branch, @KevinRansom do you want me to take care of it? I have an idea how to deal with it.

brettfo · 2022-08-29T17:39:34Z

+ <PropertyGroup>
+ <TargetFramework>net7.0</TargetFramework>
+ <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
+ <CachePath>$(MSBuildProjectDirectory)\..\..\artifacts\tmp\$([System.Guid]::NewGuid())</CachePath>


These few lines shouldn't need to be here; the auto-import of Directory.Build.props should handle it and reduce the duplication.

I'm not a fan of putting project stuff in the Directory.Build.props and targets, it makes project files so hard to reason about.

brettfo · 2022-08-29T17:40:07Z

@@ -0,0 +1,23 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+ <Import Project="$(MSBuildProjectDirectory)\..\..\eng\Versions.props" />


Might as well bump this import up to the Directory.Build.props level.

brettfo · 2022-08-29T17:41:38Z

 }

+ $verifypackageshipstatusFailed = $false
+ if ($verifypackageshipstatus) {


Related to Vlad's comment, pull this out into a separate file, something like eng/VerifyPackageShipStatus.ps1, that way it'll be easier to add as a separate build step and/or run locally.

There is a build.ps1 switch for running this:
https://github.com/dotnet/fsharp/pull/13793/files#diff-9841a029538b042b58ee9aabac3d4cd9c725a2495d81d188d23f6ad617f2a262R66
https://github.com/dotnet/fsharp/pull/13793/files#diff-9841a029538b042b58ee9aabac3d4cd9c725a2495d81d188d23f6ad617f2a262R121
So build -verifypackageshipstatus will make it easy to run.

KevinRansom · 2022-08-29T22:44:44Z

@vzarytovskii , we talked about this earlier, we agreed to run this when we merge into release branches. You can please take care of the yaml update for that :-)

* Revert tools.sh edit (#13796) * Revert tools.sh edit * Add binlog to build.sh for proto stuff * Verify ship status (#13793) * Verify ship status * -verifypackageshipstatus in the right place * more * Update Versions.props * Update azure-pipelines.yml * reactivate test - Help is displayed correctly (#13792) * tcconfig/tcconfigbuilder * add --bufferwidth * fantomas * oops Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com> Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>

KevinRansom · 2022-08-27T01:20:12Z

Now that the SDK build process automatically publishes FSharp.Core and FSharp.Compiler.Service, we need a mechanism to remind us to rev version numbers.

Here it is.

It uses an exact match packagereference to verify that the package id we think we are building hasn't been published yet.
It will run automatically on internal signed builds
not run on PR's except this one, cos I'm verifying that it works correctly in the ci environment.

It should be noted that during a build, we are not connected to nuget.org by design ... it is part of our mechanism to ensure that we don't have supply chain issues accessing public dlls.

The actual projects that we build are disconnected from the general build and set the packageroot and httpcache to a discardable location, with a random name. So ... that takes care of supply chain.

To see what it does type build -c release -verifypackageshipstatus
And observe the output this is the failing case:

KevinRansom · 2022-08-27T01:21:42Z

Hey @brettfo , I would really appreciate, you running your eyes over this.

Thanks mate

vzarytovskii · 2022-08-29T12:50:55Z

We should probably have a separate CI leg which is running on the latest release branch, @KevinRansom do you want me to take care of it? I have an idea how to deal with it.

brettfo · 2022-08-29T17:39:34Z

+ <PropertyGroup>
+ <TargetFramework>net7.0</TargetFramework>
+ <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
+ <CachePath>$(MSBuildProjectDirectory)\..\..\artifacts\tmp\$([System.Guid]::NewGuid())</CachePath>


These few lines shouldn't need to be here; the auto-import of Directory.Build.props should handle it and reduce the duplication.

I'm not a fan of putting project stuff in the Directory.Build.props and targets, it makes project files so hard to reason about.

brettfo · 2022-08-29T17:40:07Z

@@ -0,0 +1,23 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+ <Import Project="$(MSBuildProjectDirectory)\..\..\eng\Versions.props" />


Might as well bump this import up to the Directory.Build.props level.

brettfo · 2022-08-29T17:41:38Z

 }

+ $verifypackageshipstatusFailed = $false
+ if ($verifypackageshipstatus) {


Related to Vlad's comment, pull this out into a separate file, something like eng/VerifyPackageShipStatus.ps1, that way it'll be easier to add as a separate build step and/or run locally.

There is a build.ps1 switch for running this:
https://github.com/dotnet/fsharp/pull/13793/files#diff-9841a029538b042b58ee9aabac3d4cd9c725a2495d81d188d23f6ad617f2a262R66
https://github.com/dotnet/fsharp/pull/13793/files#diff-9841a029538b042b58ee9aabac3d4cd9c725a2495d81d188d23f6ad617f2a262R121
So build -verifypackageshipstatus will make it easy to run.

KevinRansom · 2022-08-29T22:44:44Z

@vzarytovskii , we talked about this earlier, we agreed to run this when we merge into release branches. You can please take care of the yaml update for that :-)

* Revert tools.sh edit (#13796) * Revert tools.sh edit * Add binlog to build.sh for proto stuff * Verify ship status (#13793) * Verify ship status * -verifypackageshipstatus in the right place * more * Update Versions.props * Update azure-pipelines.yml * reactivate test - Help is displayed correctly (#13792) * tcconfig/tcconfigbuilder * add --bufferwidth * fantomas * oops Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com> Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>

KevinRansom · 2022-08-27T01:20:12Z

Now that the SDK build process automatically publishes FSharp.Core and FSharp.Compiler.Service, we need a mechanism to remind us to rev version numbers.

Here it is.

It uses an exact match packagereference to verify that the package id we think we are building hasn't been published yet.
It will run automatically on internal signed builds
not run on PR's except this one, cos I'm verifying that it works correctly in the ci environment.

It should be noted that during a build, we are not connected to nuget.org by design ... it is part of our mechanism to ensure that we don't have supply chain issues accessing public dlls.

The actual projects that we build are disconnected from the general build and set the packageroot and httpcache to a discardable location, with a random name. So ... that takes care of supply chain.

To see what it does type build -c release -verifypackageshipstatus
And observe the output this is the failing case:

KevinRansom · 2022-08-27T01:21:42Z

Hey @brettfo , I would really appreciate, you running your eyes over this.

Thanks mate

vzarytovskii · 2022-08-29T12:50:55Z

We should probably have a separate CI leg which is running on the latest release branch, @KevinRansom do you want me to take care of it? I have an idea how to deal with it.

brettfo · 2022-08-29T17:39:34Z

+ <PropertyGroup>
+ <TargetFramework>net7.0</TargetFramework>
+ <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
+ <CachePath>$(MSBuildProjectDirectory)\..\..\artifacts\tmp\$([System.Guid]::NewGuid())</CachePath>


These few lines shouldn't need to be here; the auto-import of Directory.Build.props should handle it and reduce the duplication.

I'm not a fan of putting project stuff in the Directory.Build.props and targets, it makes project files so hard to reason about.

brettfo · 2022-08-29T17:40:07Z

@@ -0,0 +1,23 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+ <Import Project="$(MSBuildProjectDirectory)\..\..\eng\Versions.props" />


Might as well bump this import up to the Directory.Build.props level.

brettfo · 2022-08-29T17:41:38Z

 }

+ $verifypackageshipstatusFailed = $false
+ if ($verifypackageshipstatus) {


Related to Vlad's comment, pull this out into a separate file, something like eng/VerifyPackageShipStatus.ps1, that way it'll be easier to add as a separate build step and/or run locally.

There is a build.ps1 switch for running this:
https://github.com/dotnet/fsharp/pull/13793/files#diff-9841a029538b042b58ee9aabac3d4cd9c725a2495d81d188d23f6ad617f2a262R66
https://github.com/dotnet/fsharp/pull/13793/files#diff-9841a029538b042b58ee9aabac3d4cd9c725a2495d81d188d23f6ad617f2a262R121
So build -verifypackageshipstatus will make it easy to run.

KevinRansom · 2022-08-29T22:44:44Z

@vzarytovskii , we talked about this earlier, we agreed to run this when we merge into release branches. You can please take care of the yaml update for that :-)

* Revert tools.sh edit (#13796) * Revert tools.sh edit * Add binlog to build.sh for proto stuff * Verify ship status (#13793) * Verify ship status * -verifypackageshipstatus in the right place * more * Update Versions.props * Update azure-pipelines.yml * reactivate test - Help is displayed correctly (#13792) * tcconfig/tcconfigbuilder * add --bufferwidth * fantomas * oops Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com> Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>

KevinRansom · 2022-08-27T01:20:12Z

Now that the SDK build process automatically publishes FSharp.Core and FSharp.Compiler.Service, we need a mechanism to remind us to rev version numbers.

Here it is.

It uses an exact match packagereference to verify that the package id we think we are building hasn't been published yet.
It will run automatically on internal signed builds
not run on PR's except this one, cos I'm verifying that it works correctly in the ci environment.

It should be noted that during a build, we are not connected to nuget.org by design ... it is part of our mechanism to ensure that we don't have supply chain issues accessing public dlls.

The actual projects that we build are disconnected from the general build and set the packageroot and httpcache to a discardable location, with a random name. So ... that takes care of supply chain.

To see what it does type build -c release -verifypackageshipstatus
And observe the output this is the failing case:

KevinRansom · 2022-08-27T01:21:42Z

Hey @brettfo , I would really appreciate, you running your eyes over this.

Thanks mate

vzarytovskii · 2022-08-29T12:50:55Z

We should probably have a separate CI leg which is running on the latest release branch, @KevinRansom do you want me to take care of it? I have an idea how to deal with it.

brettfo · 2022-08-29T17:39:34Z

+ <PropertyGroup>
+ <TargetFramework>net7.0</TargetFramework>
+ <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
+ <CachePath>$(MSBuildProjectDirectory)\..\..\artifacts\tmp\$([System.Guid]::NewGuid())</CachePath>


These few lines shouldn't need to be here; the auto-import of Directory.Build.props should handle it and reduce the duplication.

I'm not a fan of putting project stuff in the Directory.Build.props and targets, it makes project files so hard to reason about.

brettfo · 2022-08-29T17:40:07Z

@@ -0,0 +1,23 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+ <Import Project="$(MSBuildProjectDirectory)\..\..\eng\Versions.props" />


Might as well bump this import up to the Directory.Build.props level.

brettfo · 2022-08-29T17:41:38Z

 }

+ $verifypackageshipstatusFailed = $false
+ if ($verifypackageshipstatus) {


Related to Vlad's comment, pull this out into a separate file, something like eng/VerifyPackageShipStatus.ps1, that way it'll be easier to add as a separate build step and/or run locally.

There is a build.ps1 switch for running this:
https://github.com/dotnet/fsharp/pull/13793/files#diff-9841a029538b042b58ee9aabac3d4cd9c725a2495d81d188d23f6ad617f2a262R66
https://github.com/dotnet/fsharp/pull/13793/files#diff-9841a029538b042b58ee9aabac3d4cd9c725a2495d81d188d23f6ad617f2a262R121
So build -verifypackageshipstatus will make it easy to run.

KevinRansom · 2022-08-29T22:44:44Z

@vzarytovskii , we talked about this earlier, we agreed to run this when we merge into release branches. You can please take care of the yaml update for that :-)

* Revert tools.sh edit (#13796) * Revert tools.sh edit * Add binlog to build.sh for proto stuff * Verify ship status (#13793) * Verify ship status * -verifypackageshipstatus in the right place * more * Update Versions.props * Update azure-pipelines.yml * reactivate test - Help is displayed correctly (#13792) * tcconfig/tcconfigbuilder * add --bufferwidth * fantomas * oops Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com> Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>

KevinRansom added 2 commits August 26, 2022 18:10

Verify ship status
33b6740

Merge branch 'main' into packageshipped
d1a62ef

KevinRansom requested review from brettfo and vzarytovskii August 27, 2022 01:20

KevinRansomand others added 3 commits August 26, 2022 20:48

-verifypackageshipstatus in the right place
b6c3950

more
b8818a4

Update Versions.props
5cc5025

KevinRansom changed the title ~~WIP : Do not merge : Verify ship status~~Verify ship statusAug 27, 2022

Update azure-pipelines.yml
dae21a8

Merge branch 'main' into packageshipped
69046bc

brettfo reviewed Aug 29, 2022
View reviewed changes

vzarytovskii approved these changes Aug 29, 2022
View reviewed changes

KevinRansom enabled auto-merge (squash) August 30, 2022 01:28

KevinRansom disabled auto-merge August 30, 2022 01:28

KevinRansom merged commit d8a546d into dotnet:mainAug 30, 2022

MichaelSimons mentioned this pull request Aug 30, 2022
1ES Hosted Pool provider can pick incorrect image dotnet/arcade#10248
Closed

allisonchou mentioned this pull request Sep 8, 2022
[Automated] PRs inserted in VS build main-32908.64 #13860
Closed

KevinRansom deleted the packageshipped branch October 12, 2022 20:41

KevinRansom added 2 commits August 26, 2022 18:10

Verify ship status
33b6740

Merge branch 'main' into packageshipped
d1a62ef

KevinRansom requested review from brettfo and vzarytovskii August 27, 2022 01:20

KevinRansomand others added 3 commits August 26, 2022 20:48

-verifypackageshipstatus in the right place
b6c3950

more
b8818a4

Update Versions.props
5cc5025

KevinRansom changed the title ~~WIP : Do not merge : Verify ship status~~Verify ship statusAug 27, 2022

Update azure-pipelines.yml
dae21a8

Merge branch 'main' into packageshipped
69046bc

brettfo reviewed Aug 29, 2022
View reviewed changes

vzarytovskii approved these changes Aug 29, 2022
View reviewed changes

KevinRansom enabled auto-merge (squash) August 30, 2022 01:28

KevinRansom disabled auto-merge August 30, 2022 01:28

KevinRansom merged commit d8a546d into dotnet:mainAug 30, 2022

MichaelSimons mentioned this pull request Aug 30, 2022
1ES Hosted Pool provider can pick incorrect image dotnet/arcade#10248
Closed

allisonchou mentioned this pull request Sep 8, 2022
[Automated] PRs inserted in VS build main-32908.64 #13860
Closed

KevinRansom deleted the packageshipped branch October 12, 2022 20:41

KevinRansom added 2 commits August 26, 2022 18:10

Verify ship status
33b6740

Merge branch 'main' into packageshipped
d1a62ef

KevinRansom requested review from brettfo and vzarytovskii August 27, 2022 01:20

KevinRansomand others added 3 commits August 26, 2022 20:48

-verifypackageshipstatus in the right place
b6c3950

more
b8818a4

Update Versions.props
5cc5025

KevinRansom changed the title ~~WIP : Do not merge : Verify ship status~~Verify ship statusAug 27, 2022

Update azure-pipelines.yml
dae21a8

Merge branch 'main' into packageshipped
69046bc

brettfo reviewed Aug 29, 2022
View reviewed changes

vzarytovskii approved these changes Aug 29, 2022
View reviewed changes

KevinRansom enabled auto-merge (squash) August 30, 2022 01:28

KevinRansom disabled auto-merge August 30, 2022 01:28

KevinRansom merged commit d8a546d into dotnet:mainAug 30, 2022

MichaelSimons mentioned this pull request Aug 30, 2022
1ES Hosted Pool provider can pick incorrect image dotnet/arcade#10248
Closed

allisonchou mentioned this pull request Sep 8, 2022
[Automated] PRs inserted in VS build main-32908.64 #13860
Closed

KevinRansom deleted the packageshipped branch October 12, 2022 20:41

KevinRansom added 2 commits August 26, 2022 18:10

Verify ship status
33b6740

Merge branch 'main' into packageshipped
d1a62ef

KevinRansom requested review from brettfo and vzarytovskii August 27, 2022 01:20

KevinRansomand others added 3 commits August 26, 2022 20:48

-verifypackageshipstatus in the right place
b6c3950

more
b8818a4

Update Versions.props
5cc5025

KevinRansom changed the title ~~WIP : Do not merge : Verify ship status~~Verify ship statusAug 27, 2022

Update azure-pipelines.yml
dae21a8

Merge branch 'main' into packageshipped
69046bc

brettfo reviewed Aug 29, 2022
View reviewed changes

vzarytovskii approved these changes Aug 29, 2022
View reviewed changes

KevinRansom enabled auto-merge (squash) August 30, 2022 01:28

KevinRansom disabled auto-merge August 30, 2022 01:28

KevinRansom merged commit d8a546d into dotnet:mainAug 30, 2022

MichaelSimons mentioned this pull request Aug 30, 2022
1ES Hosted Pool provider can pick incorrect image dotnet/arcade#10248
Closed

allisonchou mentioned this pull request Sep 8, 2022
[Automated] PRs inserted in VS build main-32908.64 #13860
Closed

KevinRansom deleted the packageshipped branch October 12, 2022 20:41

KevinRansom added 2 commits August 26, 2022 18:10

Verify ship status
33b6740

Merge branch 'main' into packageshipped
d1a62ef

KevinRansom requested review from brettfo and vzarytovskii August 27, 2022 01:20

KevinRansomand others added 3 commits August 26, 2022 20:48

-verifypackageshipstatus in the right place
b6c3950

more
b8818a4

Update Versions.props
5cc5025

KevinRansom changed the title ~~WIP : Do not merge : Verify ship status~~Verify ship statusAug 27, 2022

Update azure-pipelines.yml
dae21a8

Merge branch 'main' into packageshipped
69046bc

brettfo reviewed Aug 29, 2022
View reviewed changes

vzarytovskii approved these changes Aug 29, 2022
View reviewed changes

KevinRansom enabled auto-merge (squash) August 30, 2022 01:28

KevinRansom disabled auto-merge August 30, 2022 01:28

KevinRansom merged commit d8a546d into dotnet:mainAug 30, 2022

MichaelSimons mentioned this pull request Aug 30, 2022
1ES Hosted Pool provider can pick incorrect image dotnet/arcade#10248
Closed

allisonchou mentioned this pull request Sep 8, 2022
[Automated] PRs inserted in VS build main-32908.64 #13860
Closed

KevinRansom deleted the packageshipped branch October 12, 2022 20:41

KevinRansom added 2 commits August 26, 2022 18:10

Verify ship status
33b6740

Merge branch 'main' into packageshipped
d1a62ef

KevinRansom requested review from brettfo and vzarytovskii August 27, 2022 01:20

KevinRansomand others added 3 commits August 26, 2022 20:48

-verifypackageshipstatus in the right place
b6c3950

more
b8818a4

Update Versions.props
5cc5025

KevinRansom changed the title ~~WIP : Do not merge : Verify ship status~~Verify ship statusAug 27, 2022

Update azure-pipelines.yml
dae21a8

Merge branch 'main' into packageshipped
69046bc

brettfo reviewed Aug 29, 2022
View reviewed changes

vzarytovskii approved these changes Aug 29, 2022
View reviewed changes

KevinRansom enabled auto-merge (squash) August 30, 2022 01:28

KevinRansom disabled auto-merge August 30, 2022 01:28

KevinRansom merged commit d8a546d into dotnet:mainAug 30, 2022

MichaelSimons mentioned this pull request Aug 30, 2022
1ES Hosted Pool provider can pick incorrect image dotnet/arcade#10248
Closed

allisonchou mentioned this pull request Sep 8, 2022
[Automated] PRs inserted in VS build main-32908.64 #13860
Closed

KevinRansom deleted the packageshipped branch October 12, 2022 20:41

KevinRansom added 2 commits August 26, 2022 18:10

Verify ship status
33b6740

Merge branch 'main' into packageshipped
d1a62ef

KevinRansom requested review from brettfo and vzarytovskii August 27, 2022 01:20

KevinRansomand others added 3 commits August 26, 2022 20:48

-verifypackageshipstatus in the right place
b6c3950

more
b8818a4

Update Versions.props
5cc5025

KevinRansom changed the title ~~WIP : Do not merge : Verify ship status~~Verify ship statusAug 27, 2022

Update azure-pipelines.yml
dae21a8

Merge branch 'main' into packageshipped
69046bc

brettfo reviewed Aug 29, 2022
View reviewed changes

vzarytovskii approved these changes Aug 29, 2022
View reviewed changes

KevinRansom enabled auto-merge (squash) August 30, 2022 01:28

KevinRansom disabled auto-merge August 30, 2022 01:28

KevinRansom merged commit d8a546d into dotnet:mainAug 30, 2022

MichaelSimons mentioned this pull request Aug 30, 2022
1ES Hosted Pool provider can pick incorrect image dotnet/arcade#10248
Closed

allisonchou mentioned this pull request Sep 8, 2022
[Automated] PRs inserted in VS build main-32908.64 #13860
Closed

KevinRansom deleted the packageshipped branch October 12, 2022 20:41

KevinRansom added 2 commits August 26, 2022 18:10

Verify ship status
33b6740

Merge branch 'main' into packageshipped
d1a62ef

KevinRansom requested review from brettfo and vzarytovskii August 27, 2022 01:20

KevinRansomand others added 3 commits August 26, 2022 20:48

-verifypackageshipstatus in the right place
b6c3950

more
b8818a4

Update Versions.props
5cc5025

KevinRansom changed the title ~~WIP : Do not merge : Verify ship status~~Verify ship statusAug 27, 2022

Update azure-pipelines.yml
dae21a8

Merge branch 'main' into packageshipped
69046bc

brettfo reviewed Aug 29, 2022
View reviewed changes

vzarytovskii approved these changes Aug 29, 2022
View reviewed changes

KevinRansom enabled auto-merge (squash) August 30, 2022 01:28

KevinRansom disabled auto-merge August 30, 2022 01:28

KevinRansom merged commit d8a546d into dotnet:mainAug 30, 2022

MichaelSimons mentioned this pull request Aug 30, 2022
1ES Hosted Pool provider can pick incorrect image dotnet/arcade#10248
Closed

allisonchou mentioned this pull request Sep 8, 2022
[Automated] PRs inserted in VS build main-32908.64 #13860
Closed

KevinRansom deleted the packageshipped branch October 12, 2022 20:41

		@@ -0,0 +1,23 @@
		<Project Sdk="Microsoft.NET.Sdk">

		<Import Project="$(MSBuildProjectDirectory)\..\..\eng\Versions.props" />

Uh oh!

Conversation

KevinRansom commented Aug 27, 2022

Uh oh!

KevinRansom commented Aug 27, 2022

Uh oh!

vzarytovskii commented Aug 29, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KevinRansom commented Aug 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

KevinRansom commented Aug 27, 2022

Uh oh!

KevinRansom commented Aug 27, 2022

Uh oh!

vzarytovskii commented Aug 29, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KevinRansom commented Aug 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

KevinRansom commented Aug 27, 2022

Uh oh!

KevinRansom commented Aug 27, 2022

Uh oh!

vzarytovskii commented Aug 29, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KevinRansom commented Aug 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects