Uh oh!
There was an error while loading. Please reload this page.
Print empty namespace or module. - #13813
Conversation
nojaf
commented
Aug 31, 2022
@vzarytovskii@dsyme ready for review. |
There was a problem hiding this comment.
What if there are multiple items in this list?
There was a problem hiding this comment.
That is a very unlikely scenario I believe.
You can only have this with two namespaces.
Fair enough, I've added a test.
There was a problem hiding this comment.
Should we also check for TMDefRec here? Consider these (and maybe add to tests):
modulerecFoobardo()namespacerecFoobardo()There was a problem hiding this comment.
modulerecFoobardo()currently produces
moduleFoobarval``doval@3`` :unitThis probably isn't correct but is outside my scope here.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
There seems to be another edge case which could theoretically happen:
namespaceFoodo()namespaceBarmoduleBaz =do()In this case it won't be matched and namespace Foo won't be in the signatures.
There was a problem hiding this comment.
I can live with that, the goal is to avoid purely empty file generation.
This will give a result because of the nested module and that is good enough for my use case.
5cfa0e3 to
54971c5Compare0101
commented
Sep 2, 2022
@nojaf we can have a separate issue to track the remaining inconsistencies if they're too difficult to fix right now. If you can add a docstring to |
nojaf
commented
Sep 2, 2022
Thanks 👍, I see that I've added the docstring to the implementation file instead. I'll address that this afternoon. |
Fixes#13757