Skip to content

Missing xml doc for member getset - #13841

Merged
vzarytovskii merged 4 commits into
dotnet:mainfrom
nojaf:missing-xml-doc-for-member-getset
Oct 6, 2022
Merged

Missing xml doc for member getset#13841
vzarytovskii merged 4 commits into
dotnet:mainfrom
nojaf:missing-xml-doc-for-member-getset

Conversation

@nojaf

@nojafnojaf commented Sep 5, 2022

Copy link
Copy Markdown
Contributor

Related to #13833.
@auduchinok can you give an example where the XML doc is missing?

@auduchinok

Copy link
Copy Markdown
Member

@nojaf Sorry, I found an issue in our handling of the new GetSetMember, the XmlDoc is fine.

@dsyme

dsyme commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

@nojaf I presume we still want this merged? LGTM

@nojaf

nojaf commented Sep 9, 2022

Copy link
Copy Markdown
ContributorAuthor

@dsyme yes please, I believe this is still valuable.

@vzarytovskii
vzarytovskii enabled auto-merge (squash) September 15, 2022 10:02
auto-merge was automatically disabled September 26, 2022 06:09

Head branch was pushed to by a user without write access

@nojaf
nojafforce-pushed the missing-xml-doc-for-member-getset branch from d3bf71c to 4ce5e5eCompareSeptember 26, 2022 06:09
@nojaf
nojafforce-pushed the missing-xml-doc-for-member-getset branch from 63175b3 to 4296743CompareOctober 2, 2022 07:33
@vzarytovskii
vzarytovskii merged commit ffdfc71 into dotnet:mainOct 6, 2022
@nojaf
nojaf deleted the missing-xml-doc-for-member-getset branch October 6, 2022 08:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@nojaf@auduchinok@dsyme@vzarytovskii@T-Gro