Skip to content

Include range of parameter names and attributes in topTupleType SynType.Tuple - #13850

Merged
T-Gro merged 6 commits into
dotnet:mainfrom
nojaf:syntype-tuple-parameter-name
Oct 7, 2022
Merged

Include range of parameter names and attributes in topTupleType SynType.Tuple#13850
T-Gro merged 6 commits into
dotnet:mainfrom
nojaf:syntype-tuple-parameter-name

Conversation

@nojaf

@nojafnojaf commented Sep 6, 2022

Copy link
Copy Markdown
Contributor

Fixes#13848

dsyme
dsyme previously approved these changes Sep 8, 2022
@nojaf
nojafforce-pushed the syntype-tuple-parameter-name branch from a5a24bc to d97171fCompareSeptember 15, 2022 07:31
@nojaf

Copy link
Copy Markdown
ContributorAuthor

This is still fixed after taking in #13879

@dsyme

Copy link
Copy Markdown
Contributor

@nojaf So we take these tests? That's fine, thanks!

@nojaf

Copy link
Copy Markdown
ContributorAuthor

Yes, please 😊.

@nojaf
nojafforce-pushed the syntype-tuple-parameter-name branch from f97cdfd to 753ad18CompareSeptember 26, 2022 06:06
T-Gro
T-Gro previously approved these changes Oct 7, 2022
@T-Gro
T-Gro requested review from 0101, abonie and psfinakiOctober 7, 2022 11:37
T-Gro
T-Gro previously approved these changes Oct 7, 2022
@vzarytovskii

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@T-Gro
T-Gro merged commit fcd06c7 into dotnet:mainOct 7, 2022
@nojaf
nojaf deleted the syntype-tuple-parameter-name branch October 7, 2022 19:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SynType.Tuple doesn't include leading parameter names and attributes in signatures

5 participants

@nojaf@dsyme@vzarytovskii@psfinaki@T-Gro