Skip to content

Correct SynAttribute range - #13998

Merged
vzarytovskii merged 10 commits into
dotnet:mainfrom
nojaf:syn-attribute-range
Oct 6, 2022
Merged

Correct SynAttribute range#13998
vzarytovskii merged 10 commits into
dotnet:mainfrom
nojaf:syn-attribute-range

Conversation

@nojaf

@nojafnojaf commented Sep 28, 2022

Copy link
Copy Markdown
Contributor

Fixes#13983

auduchinok
auduchinok reviewed Sep 28, 2022
View reviewed changes

@auduchinokauduchinok left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nojaf Thanks for fixing it :)

Comment threadsrc/Compiler/pars.fsy Outdated
Comment threadtests/FSharp.Compiler.Service.Tests/FSharp.Compiler.Service.Tests.fsproj
@nojaf

nojaf commented Sep 29, 2022

Copy link
Copy Markdown
ContributorAuthor

@dsyme ready for review 😊.

@nojaf

nojaf commented Oct 6, 2022

Copy link
Copy Markdown
ContributorAuthor

@vzarytovskii can we have this one in main as well, please?

@vzarytovskii
vzarytovskii merged commit e389d77 into dotnet:mainOct 6, 2022
@nojaf

nojaf commented Oct 6, 2022

Copy link
Copy Markdown
ContributorAuthor

Many thanks!

@allisonchouallisonchou mentioned this pull request Oct 12, 2022
Closed
@nojaf
nojaf deleted the syn-attribute-range branch February 9, 2023 12:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskiivzarytovskiivzarytovskii approved these changes
@T-GroT-GroT-Gro approved these changes
+1 more reviewer
@auduchinokauduchinokauduchinok left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The range of SynAttribute looks incorrect.

4 participants

@nojaf@vzarytovskii@auduchinok@T-Gro