Uh oh!
There was an error while loading. Please reload this page.
Eagerly format exceptions in FSI's interactive scripting API - #14026
Merged
Conversation
abonieforce-pushed
the
exception_eager_formatting
branch
2 times, most recently
from
October 6, 2022 12:04
1258f09 to
93c68bdCompareabonie
marked this pull request as ready for review
October 6, 2022 12:05
KevinRansom
previously approved these changes
Oct 6, 2022
KevinRansom
enabled auto-merge (squash)
October 6, 2022 19:16
psfinaki
previously approved these changes
Oct 7, 2022
Uh oh!
There was an error while loading. Please reload this page.
0101
reviewed
Oct 7, 2022
Uh oh!
There was an error while loading. Please reload this page.
abonieforce-pushed
the
exception_eager_formatting
branch
from
October 7, 2022 14:14
faa18d7 to
a3e432bCompareabonie
marked this pull request as draft
October 7, 2022 14:15
auto-merge was automatically disabled
October 7, 2022 14:15
Pull request was converted to draft
Eval* methods of FSIEvaluationSession that are using CompilationDiagnosticsLogger are at risk of mutating data that's referred to in the exception before error message is printed. To prevent that, this commit makes CompilationDiagnosticsLogger take additional argument that can control early pre-processing of logged exceptions.
abonieforce-pushed
the
exception_eager_formatting
branch
from
October 7, 2022 14:23
a3e432b to
caf35fdCompareabonie
marked this pull request as ready for review
October 7, 2022 14:24
abonie
commented
Oct 7, 2022
MemberAuthor
abonie
enabled auto-merge (squash)
October 7, 2022 14:46
psfinaki
approved these changes
Oct 7, 2022
0101
approved these changes
Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds eager formatting of exceptions to CompilationDiagnosticLogger (which accumulates exceptions in an array) in FsiEvaluationSession.
This should fix#13921 which was due to the fact, that type variables contained in ValueRestriction exception were mutated before diagnostics were committed.
Not sure whether this same approach should be used wider or not.