Uh oh!
There was an error while loading. Please reload this page.
Leading keyword synbinding - #14056
Merged
Merged
Conversation
nojafforce-pushed
the
leading-keyword-synbinding
branch
from
October 9, 2022 14:46
3d04933 to
06355a0Comparenojaf
marked this pull request as ready for review
October 9, 2022 16:35
nojafforce-pushed
the
leading-keyword-synbinding
branch
from
October 10, 2022 12:36
0d46542 to
b431f2aComparenojafforce-pushed
the
leading-keyword-synbinding
branch
from
October 10, 2022 14:52
4d6dc12 to
43542a2Comparenojaf
commented
Oct 12, 2022
ContributorAuthor
@T-Gro can I get a review on this as well, please? |
0101
reviewed
Oct 12, 2022
Uh oh!
There was an error while loading. Please reload this page.
T-Gro
previously approved these changes
Oct 12, 2022
T-Gro
previously approved these changes
Oct 12, 2022
0101
previously approved these changes
Oct 12, 2022
0101
previously approved these changes
Oct 12, 2022
T-Gro
previously approved these changes
Oct 12, 2022
T-Gro
enabled auto-merge (squash)
October 12, 2022 13:30
auto-merge was automatically disabled
October 12, 2022 14:07
Head branch was pushed to by a user without write access
0101
approved these changes
Oct 12, 2022
nojaf
commented
Oct 13, 2022
ContributorAuthor
@T-Gro good to go? |
T-Gro
approved these changes
Oct 13, 2022
nojaf
commented
Oct 13, 2022
ContributorAuthor
Thanks, can I get the auto-merge thing, please 😇? |
nojaf
commented
Oct 13, 2022
ContributorAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #14030, I realized that there could be a better approach to all of this.
The nice thing here is that you can tell from an individual SynBinding what keywords it had. No need to rely on the parent context and no duplicate information.