Skip to content

Clean up F# OSS build targets files. - #1422

Merged
KevinRansom merged 4 commits into
dotnet:masterfrom
KevinRansom:master
Aug 12, 2016
Merged

Clean up F# OSS build targets files.#1422
KevinRansom merged 4 commits into
dotnet:masterfrom
KevinRansom:master

Conversation

@KevinRansom

Copy link
Copy Markdown
Contributor
  1. Use public sign.
  2. fix some slightly irritating indentation.
  3. Move release and debug speciffic settings to settings.targets
  4. Remove TargetFramework support for platforms that are not part of the OSS build.

1. Use public sign.
2. fix some slightly irritating indentation.
3. Move release and debug speciffic settings to settings.targets
4. Remove TargetFramework support for platforms that are not part of the OSS build.
@dsyme

dsyme commented Aug 12, 2016

Copy link
Copy Markdown
Contributor

For those who want to know what public signing is: #1376 (comment)

@KevinRansom

Copy link
Copy Markdown
ContributorAuthor

Public signing is kind of a loader trick. Delay the sign the dll, and mark the signed bit in the CLR header to signed and the CLR loads the dll fine, except where it would normally verify the assembly, So public signed assemblies can not be used in Partial App Domains or from the GAC.

Official Microsoft Binaries will still be fully signed using the .net framework keypair. This is just a way of removing the administrator and skip verification requirement when building our OSS binaries

Kevin

<!-- Standard interpretations of Debug and Release configurations -->
<PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">
<DebugType Condition=" '$(DebugType)' == '' ">full</DebugType>
<DebugType Condition=" '$(DebugType)' == '' ">portable</DebugType>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will affect all projects?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VS2014 and Dev15 from Update 2 onwaqrds can both debug portable PDB's, and portable PDBs are much ... much smaller.

@KevinRansom
KevinRansom merged commit 7cfe41e into dotnet:masterAug 12, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@KevinRansom@dsyme@OmarTawfik@msftclas