Uh oh!
There was an error while loading. Please reload this page.
Add while! (while bang) - #14238
Conversation
Uh oh!
There was an error while loading. Please reload this page.
KevinRansom
commented
Nov 4, 2022
This is nice, good work. |
Uh oh!
There was an error while loading. Please reload this page.
vzarytovskii
commented
Nov 26, 2022
How does it/will it behave in the resumable code? Probably needs some tests/changes to the resumable intrinsics? |
kerams
commented
Nov 26, 2022
Added a test with a task CE, and other than the fact that it produces a warning saying it's not statically compilable, which I can do nothing about, it looks good. |
One outstanding issue is the fact that there are multiple extraneous debug points on the guard condition. I don't quite understand how they're emitted since I thought I suppressed them all. |
vzarytovskii
commented
Jul 20, 2023
I think @abonie is looking at sequence points generation. Might have an effect on this one as well? |
abonie
commented
Jul 21, 2023
At the moment I am only looking at #15289 as far sequence points go, but tbh can't repro it anywhere else |
psfinaki
left a comment
There was a problem hiding this comment.
I am not entirely able to evaluate the changes in the parser core - but otherwise this looks good. Definitely worth bringing back to life, probably with some minimal docs (can be a followup).
Thanks for this! (and for removing some code dupes as well)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Implements fsharp/fslang-suggestions#1038.