Uh oh!
There was an error while loading. Please reload this page.
New codefix provider to remove superflous binding for a Union case that has 0 fields. - #14267
Conversation
T-Gro
commented
Nov 8, 2022
/run fantomas |
Failed to run fantomas: https://github.com/dotnet/fsharp/actions/runs/3419732464 |
vzarytovskii
commented
Nov 8, 2022
Huh, interesting that it failed to run fantomas. Need to check what's up with it |
edgarfgp
commented
Nov 8, 2022
@T-Gro This looks awesome . |
kerams
commented
Nov 8, 2022
fsharp/fslang-suggestions#1094 would be a godsend in cases like this. |
T-Gro
commented
Nov 8, 2022
Oh yes, the relevant part of the tree when spotting a diagnostic (since it is available "at hand") could directly flow with it. |
edgarfgp
commented
Nov 23, 2022
@T-Gro While I was adding the same quick fix for Rider. I notice that we can also use the same quick fix for typeE=| A =1| B =2let(E.A x)= E.A
match E.A with| E.A x ->()let [<Literal>]A=1match1with|(A x)->()See JetBrains/resharper-fsharp#444 for more info |
This kicks in when:
This builds on top of the new diagnostics added via #14055
CodeFixRemoveSuperflousBinding.mp4