Skip to content

I'm shy test. Please don't ignore me - #14305

Closed
kant2002 wants to merge 1 commit into
dotnet:mainfrom
kant2002:patch-1
Closed

I'm shy test. Please don't ignore me#14305
kant2002 wants to merge 1 commit into
dotnet:mainfrom
kant2002:patch-1

Conversation

@kant2002

Copy link
Copy Markdown
Contributor

My older brother just join your club. I'm want to be part of the test suite too.

My older brother just join your club. I'm want to be part of the test suite too.
@kant2002
kant2002 requested a review from a team as a code ownerNovember 13, 2022 18:51

@KevinRansomKevinRansom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vzarytovskii --- can you take a look.

@T-Gro

Copy link
Copy Markdown
Member

Mismatch in error message, expected '"The type 'float' is not compatible with the type 'ITrigonometricFunctions<float>'"' was not found during compilation

@T-Gro

Copy link
Copy Markdown
Member

Whereas the actual error in the failing tests is:

["Error 39 "The type 'ITrigonometricFunctions' is not defined."";
"Error 3533 "Invalid constraint. Valid constraint forms include "'T :> ISomeInterface" for interface constraints and "SomeConstrainingType<'T>" for self-constraints. See https://aka.ms/fsharp-type-constraints.""]

@vzarytovskii

Copy link
Copy Markdown
Member

I'll take a look at it, we're likely just didn't use correct interfaces from bcl.

@vzarytovskiivzarytovskii added this to the November-2022 milestone Nov 14, 2022
@vzarytovskiivzarytovskii self-assigned this Nov 14, 2022
@vzarytovskii

vzarytovskii commented Nov 14, 2022

Copy link
Copy Markdown
Member

Ok, I've re-enabled those as part of #14294 last week, and fixed them there.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants

@kant2002@T-Gro@vzarytovskii@KevinRansom