Uh oh!
There was an error while loading. Please reload this page.
Add FsharpType.MakeStructTupleType overload that does not accept an assembly - #14504
Conversation
…load-that-does-not-accept-an-assembly
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vzarytovskii
commented
Dec 21, 2022
Since it's a breaking change (existing method is getting |
Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>
Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…load-that-does-not-accept-an-assembly
abelbraaksma
commented
Dec 22, 2022
Just curious, the change makes total sense, but is there a tracking issue or is this just general cleanup? Since we stopped updating the changelog (I’d love to have that back, but that’s OT), in particular with backward compat issues, having a tracking issue would be nice. |
T-Gro
commented
Dec 27, 2022
Only this: |
T-Gro
commented
Dec 27, 2022
You meant a tracking issue for all API-relevant-changes to be linked into, right? |
Yes, that’s what I meant. Usually it’s referenced in the PR description if there is one (and afaik, you usually link it), hence me wondering ;). |
Understood, just not seeing an appropriate one. |
abelbraaksma
commented
Dec 30, 2022
Actually, I just meant linking #14398. But you’re right, a tracking issue to list API changes is something we’ve used in the past and would be really useful. |
T-Gro
commented
Jan 6, 2023
Deprecation via |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…load-that-does-not-accept-an-assembly
Uh oh!
There was an error while loading. Please reload this page.
…load-that-does-not-accept-an-assembly
…load-that-does-not-accept-an-assembly
Uh oh!
There was an error while loading. Please reload this page.
…load-that-does-not-accept-an-assembly
Addresses #14398
Make a new FsharpType.MakeStructTupleType overload that does not accept an assembly argument
Obsolete existing members in reflection and quotations that still need it
Change the inner implementation to be lock-free and work with netstandard ref-tuples and struct-tuples
Add new tests (e.g. for 'tuple nesting' behaviour)
Inner workings of Obsolete code moved to a separate module, to make them easy to delete once API surface can be reduced