Skip to content

Ditch DictImp GetEnumerator<T> code that was needed because of a runtime bug - #14509

Merged
T-Gro merged 1 commit into
mainfrom
dictionary-impl-enumerable-via-SZGenericEnumerators
Jan 5, 2023
Merged

Ditch DictImp GetEnumerator<T> code that was needed because of a runtime bug#14509
T-Gro merged 1 commit into
mainfrom
dictionary-impl-enumerable-via-SZGenericEnumerators

Conversation

@T-Gro

Copy link
Copy Markdown
Member

This bug has been fixed in the meantime.
Original issue:
F#: #5910
Runtime: dotnet/runtime#11488

Resolution in runtime repo:
dotnet/coreclr#21368

Tests:
image

@T-Gro
T-Gro requested a review from a team as a code ownerDecember 22, 2022 14:11
@vzarytovskii

vzarytovskii commented Dec 27, 2022

Copy link
Copy Markdown
Member

So, what happens if FSharp.Core with this change is loaded into runtime with bug present? Or was the fix backported to all branches?

@T-Gro

Copy link
Copy Markdown
MemberAuthor

So, what happens if FSharp.Core with this change is loaded into runtime with bug present? Or was the fix backported to all branches?

The worst case is that repeated access to .Current after enumeration has finished (MoveNext() returned false) will not throw.

I tried searching trough the runtime repo, but I do not see links which would tell me which versions this went into.
I can only see it is a little over 4 years ago since it was merged to main.
dotnet/coreclr#21368

@T-Gro

Copy link
Copy Markdown
MemberAuthor

But since it was 4 years ago, it means that versions 6 and 7 have it (the only supported versions as of now?).

0101
0101 approved these changes Jan 2, 2023
@T-Gro
T-Gro merged commit 73c9074 into mainJan 5, 2023
@T-Gro
T-Gro deleted the dictionary-impl-enumerable-via-SZGenericEnumerators branch January 5, 2023 09:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants

@T-Gro@vzarytovskii@0101@psfinaki