Uh oh!
There was an error while loading. Please reload this page.
Not constructor arguments are allowed in static classes - #14512
Conversation
edgarfgp
commented
Dec 28, 2022
@T-Gro Any idea why the CI is failing ? . It seem to be related to my changes but Im failing to understand why :( |
…lasses' of https://github.com/edgarfgp/fsharp into compiler-warning-when-constructor-arguments-in-static-classes
T-Gro
commented
Dec 29, 2022
Will have a look |
Uh oh!
There was an error while loading. Please reload this page.
T-Gro
commented
Dec 29, 2022
Made a few pushes already:
|
…solution is not production ready
T-Gro
commented
Dec 29, 2022
@edgarfgp Check the current code and commit log.
We can chat on Slack if you want to discuss this |
edgarfgp
commented
Dec 29, 2022
Thanks @T-Gro :) . |
edgarfgp
commented
Jan 3, 2023
@T-Gro I found a later phase to do the attribute checking (Thanks for your help). Now that the CI is happy, I wanted to double-check if that error message and the ranges are clear enough. Any feedback is welcome :) |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
T-Gro
commented
Jan 3, 2023
Left a suggestion. I would rather avoid putting verbs (are,is,..) into in and want to have them as part of the template, because different languages have different word order rules as well as negation rules. As long as it is the template, translator can change both the sentence as well as placement of the '%s' expression. |
vzarytovskii
commented
Jan 3, 2023
As discussed on slack, we should probably use different errors for each case, as oppose to having one interpolated (which won't go well with localizations). |
edgarfgp
commented
Jan 4, 2023
@vzarytovskii Updated as discussed in Slack :) |
edgarfgp
commented
Jan 5, 2023
@0101 by Any chance I have another review and hopefully merge it? So I can continue adding errors on static classes? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
0101
left a comment
There was a problem hiding this comment.
Looks good. But I think we should fix the capitalization in the error messages.
Co-authored-by: Petr Pokorny <petr@innit.cz>
Fixes one the multiple missing error reporting in #13147
This PR adds:
[<Sealed; AbstractClass>]I will adding more error reporting in the future :)