Skip to content

Compiler error when using instance members on static class - #14555

Merged
T-Gro merged 2 commits into
dotnet:mainfrom
edgarfgp:compiler-error-instance-member-static-classes
Jan 9, 2023
Merged

Compiler error when using instance members on static class#14555
T-Gro merged 2 commits into
dotnet:mainfrom
edgarfgp:compiler-error-instance-member-static-classes

Conversation

@edgarfgp

Copy link
Copy Markdown
Contributor

Fixes one the multiple missing error reporting in #13147

@edgarfgp
edgarfgp requested a review from a team as a code ownerJanuary 6, 2023 15:58
KevinRansom
KevinRansom previously approved these changes Jan 6, 2023

@KevinRansomKevinRansom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

psfinaki
psfinaki previously approved these changes Jan 6, 2023

@psfinakipsfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few grammar remarks, otherwise all good

Comment threadtests/FSharp.Compiler.ComponentTests/Language/StaticClassTests.fs Outdated
Comment threadsrc/Compiler/FSComp.txt Outdated
@edgarfgp
edgarfgp dismissed stale reviews from psfinaki and KevinRansom via aaec8b9January 7, 2023 07:56
@edgarfgp
edgarfgp requested a review from psfinakiJanuary 7, 2023 15:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants

@edgarfgp@KevinRansom@psfinaki@T-Gro@vzarytovskii