FCS: Enable error reporting with correct file name

[goswinr]

Currently, compiler errors in fsi evaluations via FCS always report an error in a file called input.fsx.
This pull request adds an optional parameteroverload that allows specifying a filename related to an evaluated string.

For example, calling fsiSession.EvalInteraction( "1 + 1.0" ) reports input.fsx (1,3)-(1,4) typecheck error The type 'float' does not match the type 'int'
But the actual file where this string comes from might be named differently.

I don't want to use fsiSession.EvalScript(path) since a file might not exist yet, or I might not be evaluating all lines of the current file.

[T-Gro]

I know it probably isn't a big deal, but I would prefer if this would be done without breaking binary compatibility.
i.e. adding a new overload, and keeping the existing one WITHOUT requiring consuming code to be recompiled.

(in this case the code overhead is negligable)

[goswinr]

@T-Gro sure , I can change the PR. I was not sure how to best expose the dummyScriptFileName . So instead of two optional members there should be and overload with two required members ( and the cancellation token still optional) ?

[T-Gro]

@T-Gro sure , I can change the PR. I was not sure how to best expose the dummyScriptFileName . So instead of two optional members there should be and overload with two required members ( and the cancellation token still optional) ?

Yep.

Because adding an optional member to existing functionality requires recompilation (with no code changes on consumer side), but is binary breaking.

A new overload would keep existing usages working.

[KevinRansom]

As Tomas says, overloads are preferred for compatibility.

[goswinr]

@T-Gro , @KevinRansom I changed it to overloads. I also rebased it to use the new basline files for the API surface.

the new overloads are:

memberEvalInteraction:code:string * scriptFileName: string * ?cancellationToken: CancellationToken -> unitmember EvalInteractionNonThrowing: code: string * scriptFileName: string * ?cancellationToken: CancellationToken -> Choice<FsiValue option, exn>* FSharpDiagnostic[]member EvalExpression: code: string * scriptFileName: string -> FsiValue optionmember EvalExpressionNonThrowing: code: string * scriptFileName: string -> Choice<FsiValue option, exn>* FSharpDiagnostic[]

the existing ones:

memberEvalInteraction:code:string * ?cancellationToken: CancellationToken -> unitmember EvalInteractionNonThrowing: code: string * ?cancellationToken: CancellationToken -> Choice<FsiValue option, exn>* FSharpDiagnostic[]member EvalExpression: code: string -> FsiValue optionmember EvalExpressionNonThrowing: code: string -> Choice<FsiValue option, exn>* FSharpDiagnostic[]

In my own tests the scriptFileName now also shows for __SOURCE_FILE__ in scripts.

Addressed

[goswinr]

Thanks @vzarytovskii ! Is there also some fcs documentation to update ?

[vzarytovskii]

Thanks @vzarytovskii ! Is there also some fcs documentation to update ?

I don't think there's, docs should be automatically generated

[goswinr]

Thanks for merging @vzarytovskii ! However, I did not find this in the new Nuget that was published yesterday.
Is there a preview nuget that contains this change?

[vzarytovskii]

Thanks for merging @vzarytovskii ! However, I did not find this in the new Nuget that was published yesterday.
Is there a preview nuget that contains this change?

I don't think it made it to .200, it should be in the next .300 preview or our preview nuget feed.