Uh oh!
There was an error while loading. Please reload this page.
Update fslex and fsyacc to 11.0.1 - #14584
Conversation
vzarytovskii
commented
Jan 11, 2023
That's a lot of changes @nojaf do you happen to know if I can easily find commits list in the fslexyacc repo, which were included in the release? |
vzarytovskii
commented
Jan 11, 2023
@dsyme was fslexyacc changed in any way when having a local copy of compiler? Because in this case, just updating it from upstream might not work properly. |
nojaf
commented
Jan 11, 2023
Do you have any idea what release you were on, to begin with? All the CI passed (expect for something which I believe to be unrelated, https://github.com/dotnet/fsharp/runs/10576589137) |
vzarytovskii
commented
Jan 11, 2023
Yep, apparently one of the last updates was in #6355 to 8.0.1 |
nojaf
commented
Jan 11, 2023
That would explain why there are so many changes I guess. |
Uh oh!
There was an error while loading. Please reload this page.
dsyme
commented
Jan 11, 2023
I looked through and didn't see any changes in fslex or fsyacc that affect how the grammar is being processed. By the look of it I would expect exactly the same tables and generated source to be generated |
nojaf
commented
Jan 12, 2023
@dsyme@vzarytovskii is there anything left to address here? |
dsyme
commented
Jan 13, 2023
For me this is ok |
Fixes#14583
I copied to source from the 11.0.1