Uh oh!
There was an error while loading. Please reload this page.
Remove unused code - #14589
Conversation
KevinRansom
left a comment
There was a problem hiding this comment.
I love this change, but I want to understand whether the reordering of the baseline file is benign.
Also there is too much churn in that file to see whether something interesting was removed.
So if we can hold off on merging for a short while.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
T-Gro
commented
Jan 11, 2023
I want to nominate this for PR of the year. |
KevinRansom
commented
Jan 12, 2023
I'm gonna do the baselines for this differently, so the big delta here is fine for now. |
KevinRansom
left a comment
There was a problem hiding this comment.
Now I think I understand what is going on with the baseline.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nojaf
commented
Jan 13, 2023
@T-Gro I've addressed all the remarks. This one is good to go. |
In light of #14567, I believe to have found some code that is unused.
These are top-level functions that are unused in the file they are defined and are not part of the signature.
In some cases, I did update the signature file. (For example in
Result.toSeqin FSharp.Core, because the value was missing insrc/FSharp.Core/result.fsiit was considered unused).And in
sformat.fsI did shuffle some functions a bit because depending on theCOMPILERdefine value the code was considered to be unused or not. This file is used both inFCSandFSharp.Core.