Skip to content

Add SynMemberDefnImplicitCtorTrivia. - #14654

Merged
T-Gro merged 4 commits into
dotnet:mainfrom
nojaf:as-trivia
Jan 30, 2023
Merged

Add SynMemberDefnImplicitCtorTrivia.#14654
T-Gro merged 4 commits into
dotnet:mainfrom
nojaf:as-trivia

Conversation

@nojaf

@nojafnojaf commented Jan 24, 2023

Copy link
Copy Markdown
Contributor

In order to solve fsprojects/fantomas#2733, I would like to know the location of the as keyword for SynMemberDefn.ImplicitCtor.

//cc @vzarytovskii

@nojaf
nojaf requested a review from a team as a code ownerJanuary 24, 2023 14:00
T-Gro
T-Gro reviewed Jan 24, 2023
View reviewed changes
Comment threadtests/service/SyntaxTreeTests/MemberTests.fs
psfinaki
psfinaki approved these changes Jan 30, 2023
View reviewed changes

@psfinakipsfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment threadtests/service/SyntaxTreeTests/MemberTests.fs
@T-Gro
T-Gro merged commit 924a64e into dotnet:mainJan 30, 2023
@nojaf
nojaf deleted the as-trivia branch January 30, 2023 13:36
@allisonchouallisonchou mentioned this pull request Feb 17, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-GroT-GroT-Gro approved these changes
+1 more reviewer
@psfinakipsfinakipsfinaki approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release/17.6

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nojaf@psfinaki@T-Gro@vzarytovskii