Skip to content

Include settable properties in attribute completions - #14697

Merged
T-Gro merged 6 commits into
dotnet:mainfrom
kerams:att
Feb 10, 2023
Merged

Include settable properties in attribute completions#14697
T-Gro merged 6 commits into
dotnet:mainfrom
kerams:att

Conversation

@kerams

@keramskerams commented Feb 5, 2023

Copy link
Copy Markdown
Contributor

Fixes#14696.

I've introduced SyntaxVisitorBase.VisitAttributeApplication to make attribute application traversal more uniform.

@kerams
kerams requested a review from a team as a code ownerFebruary 5, 2023 19:00
kerams
kerams commented Feb 5, 2023
View reviewed changes
Comment threadsrc/Compiler/Service/ServiceParsedInputOps.fs
kerams
kerams commented Feb 5, 2023
View reviewed changes
Comment threadsrc/Compiler/Service/ServiceParsedInputOps.fs
@kerams

kerams commented Feb 5, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Ok, so the AutoCompletion.escaped with backticks test passes in isolation and when run before AutoCompletion.BeforeThis. Thoughts?

Migrated it from the legacy test suite, so it should hopefully be fine now.

@0101

0101 commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

Ok, so the AutoCompletion.escaped with backticks test passes in isolation and when run before AutoCompletion.BeforeThis. Thoughts?

Migrated it from the legacy test suite, so it should hopefully be fine now.

Since it was under legacy language service I'd say it's ok.

0101
0101 approved these changes Feb 6, 2023
View reviewed changes
@T-Gro
T-Gro merged commit a2c0c22 into dotnet:mainFeb 10, 2023
@kerams
kerams deleted the att branch February 10, 2023 23:07
@allisonchouallisonchou mentioned this pull request Feb 17, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonieabonieabonie approved these changes
@T-GroT-GroT-Gro approved these changes
+1 more reviewer
@010101010101 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release/17.6

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Properties are not included in Attribute completion list

5 participants

@kerams@0101@abonie@T-Gro@vzarytovskii