Skip to content

Clean up NameResolution.fs - #14722

Merged
T-Gro merged 2 commits into
dotnet:mainfrom
kerams:clean
Feb 10, 2023
Merged

Clean up NameResolution.fs#14722
T-Gro merged 2 commits into
dotnet:mainfrom
kerams:clean

Conversation

@kerams

@keramskerams commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

Factoring out some common bits.

@kerams
kerams requested a review from a team as a code ownerFebruary 9, 2023 10:54
kerams
kerams commented Feb 9, 2023
View reviewed changes
Comment threadsrc/Compiler/Facilities/DiagnosticsLogger.fs Outdated
psfinaki
psfinaki approved these changes Feb 9, 2023
View reviewed changes

@psfinakipsfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kerams. Keep rocking :)

Comment threadsrc/Compiler/Checking/NameResolution.fs
@T-Gro
T-Gro merged commit 337d0af into dotnet:mainFeb 10, 2023
@kerams
kerams deleted the clean branch February 10, 2023 22:24
@allisonchouallisonchou mentioned this pull request Feb 17, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskiivzarytovskiivzarytovskii approved these changes
@T-GroT-GroT-Gro approved these changes
+2 more reviewers
@forkiforkiforki left review comments
@psfinakipsfinakipsfinaki approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release/17.6

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kerams@forki@vzarytovskii@psfinaki@T-Gro