Skip to content

Don't check the unfinished expression before dot as the whole expression - #14801

Merged
vzarytovskii merged 2 commits into
dotnet:mainfrom
auduchinok:tc-mkSynDotMissing2
Feb 27, 2023
Merged

Don't check the unfinished expression before dot as the whole expression#14801
vzarytovskii merged 2 commits into
dotnet:mainfrom
auduchinok:tc-mkSynDotMissing2

Conversation

@auduchinok

@auduchinokauduchinok commented Feb 24, 2023

Copy link
Copy Markdown
Member

A continuation of #14718. It turned out, it got broken back when I tried to fix the tests, since LongOrSingleIdent is also used in TcExprThen.

Adds a recovery test.

@auduchinok
auduchinok requested a review from a team as a code ownerFebruary 24, 2023 10:40
KevinRansom
KevinRansom approved these changes Feb 27, 2023
View reviewed changes

@KevinRansomKevinRansom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vzarytovskii
vzarytovskii merged commit d415ef9 into dotnet:mainFeb 27, 2023
@auduchinok
auduchinok deleted the tc-mkSynDotMissing2 branch February 27, 2023 15:54
@allisonchouallisonchou mentioned this pull request Mar 8, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskiivzarytovskiivzarytovskii approved these changes
+1 more reviewer
@KevinRansomKevinRansomKevinRansom approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release/17.6

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@auduchinok@vzarytovskii@KevinRansom