Uh oh!
There was an error while loading. Please reload this page.
Simplify GraphNode - #14908
Merged
Merged
Conversation
En3Tho
reviewed
Mar 16, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
KevinRansom
approved these changes
Mar 16, 2023
T-Gro
approved these changes
Mar 17, 2023
T-Gro
commented
Mar 20, 2023
Member
Ready to merge? |
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
retryCompute = falsemechanism, which is supposed to avoid repeating computation when the first requestor cancels, is unused. Deleting it makes it a bit easier to deal withGraphNode.This PR also removes a lock and replaces it with
Interlocked.Increment/Decrement.