Skip to content

Fix some blocking in incremental builder - #15146

Merged
0101 merged 3 commits into
dotnet:mainfrom
majocha:fix-blocking
Apr 27, 2023
Merged

Fix some blocking in incremental builder#15146
0101 merged 3 commits into
dotnet:mainfrom
majocha:fix-blocking

Conversation

@majocha

Copy link
Copy Markdown
Contributor

Synchronous GetLogicalTimeStamp* calls were needlessly updating currentState, which is guarded by a semaphore, just to find out the up-to-date timestamps.

cc: @0101

@majocha
majocha requested a review from a team as a code ownerApril 26, 2023 17:40
@majocha

Copy link
Copy Markdown
ContributorAuthor

OK this is just reverted to the original, until I fully understand it. Should be fine when green.

@0101
0101 merged commit 9627d33 into dotnet:mainApr 27, 2023
@majocha
majocha deleted the fix-blocking branch November 23, 2023 15:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants

@majocha@0101@vzarytovskii