Skip to content

Improve perf of extension methods without type attribute - #15169

Merged
vzarytovskii merged 1 commit into
dotnet:mainfrom
nojaf:perf/extension-methods-without-type-attribute
May 2, 2023
Merged

Improve perf of extension methods without type attribute#15169
vzarytovskii merged 1 commit into
dotnet:mainfrom
nojaf:perf/extension-methods-without-type-attribute

Conversation

@nojaf

@nojafnojaf commented May 2, 2023

Copy link
Copy Markdown
Contributor

Trying out the suggestion from Don at #13839 (comment)
//cc @edgarfgp

@nojaf
nojaf requested a review from a team as a code ownerMay 2, 2023 07:11
@T-Gro

T-Gro commented May 2, 2023

Copy link
Copy Markdown
Member

(I restarted CI because Linux build timed out. But I did not see any other issues => looks good)

@edgarfgpedgarfgp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Florian :)

@psfinakipsfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, any benchmarks on this?

@vzarytovskii
vzarytovskii merged commit 8746c3a into dotnet:mainMay 2, 2023
@nojaf

nojaf commented May 2, 2023

Copy link
Copy Markdown
ContributorAuthor

Cool, any benchmarks on this?

No, not really.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants

@nojaf@T-Gro@vzarytovskii@psfinaki@edgarfgp