Skip to content

Use idText for PropertyGetterMethod and PropertySetterMethod - #15213

Merged
vzarytovskii merged 4 commits into
dotnet:mainfrom
nojaf:get-set-symbol
May 16, 2023
Merged

Use idText for PropertyGetterMethod and PropertySetterMethod#15213
vzarytovskii merged 4 commits into
dotnet:mainfrom
nojaf:get-set-symbol

Conversation

@nojaf

@nojafnojaf commented May 11, 2023

Copy link
Copy Markdown
Contributor

Fixes#15212

@nojaf
nojaf requested a review from a team as a code ownerMay 11, 2023 10:06
vzarytovskii
vzarytovskii reviewed May 11, 2023
View reviewed changes
Comment threadsrc/Compiler/Checking/NameResolution.fs
auduchinok
auduchinok reviewed May 11, 2023
View reviewed changes
Comment threadtests/service/ProjectAnalysisTests.fs
auduchinok
auduchinok reviewed May 11, 2023
View reviewed changes
Comment threadtests/service/Symbols.fs
@vzarytovskii
vzarytovskii merged commit b9b69ff into dotnet:mainMay 16, 2023
@allisonchouallisonchou mentioned this pull request May 19, 2023
Closed
@nojafnojaf mentioned this pull request Jun 21, 2023
Merged
@nojafnojaf mentioned this pull request Jul 12, 2023
Merged
@nojafnojaf mentioned this pull request Oct 12, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskiivzarytovskiivzarytovskii approved these changes
+2 more reviewers
@auduchinokauduchinokauduchinok left review comments
@edgarfgpedgarfgpedgarfgp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release/17.7

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No Symbol for setter is created

4 participants

@nojaf@vzarytovskii@auduchinok@edgarfgp