Skip to content

Add fallback range to more typars - #15301

Merged
psfinaki merged 8 commits into
dotnet:mainfrom
Smaug123:add-fallback-range
Jun 5, 2023
Merged

Add fallback range to more typars#15301
psfinaki merged 8 commits into
dotnet:mainfrom
Smaug123:add-fallback-range

Conversation

@Smaug123

Copy link
Copy Markdown
Contributor

And a sneaky removal of trailing whitespace, and a reordering of a pair of args to help in pipelines.

This adds a backup range in more cases, and it turns out to be enough for #13298 .

@Smaug123
Smaug123 requested a review from a team as a code ownerJune 2, 2023 16:18
Comment threadtests/FSharp.Test.Utilities/Compiler.fs
@Smaug123

Copy link
Copy Markdown
ContributorAuthor

I haven't done an explicit formatting; that was my editor trimming whitespace. I can undo it if you want.

@nojafnojaf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some nitpicks on some names, this looks fine, however.

Comment threadsrc/Compiler/Checking/FindUnsolved.fs Outdated
Comment threadsrc/Compiler/Checking/FindUnsolved.fs Outdated
@psfinaki
psfinaki enabled auto-merge (squash) June 5, 2023 17:49
@psfinaki
psfinaki merged commit 807489f into dotnet:mainJun 5, 2023
@Smaug123
Smaug123 deleted the add-fallback-range branch June 5, 2023 18:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants

@Smaug123@nojaf@psfinaki@edgarfgp@T-Gro@vzarytovskii