Skip to content

[Draft] make ParseAndCheckProject report all diagnostics again - #15342

Closed
majocha wants to merge 51 commits into
dotnet:mainfrom
majocha:ib-reduce-complexity
Closed

[Draft] make ParseAndCheckProject report all diagnostics again#15342
majocha wants to merge 51 commits into
dotnet:mainfrom
majocha:ib-reduce-complexity

Conversation

@majocha

@majochamajocha commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Just to check if it's green.
Fixes#15337

@majocha
majochaforce-pushed the ib-reduce-complexity branch from bde9882 to cc14659CompareJune 8, 2023 07:45
@majocha

Copy link
Copy Markdown
ContributorAuthor

Hmm, bummer. This test consistently passes locally:
image

@majocha

Copy link
Copy Markdown
ContributorAuthor

Ok, so this is green. I'll do some manual testing later when I'm back at my PC to make sure it actually works.
I did this fix is on top of some unrelated clean-up for the sake of more quickly trying stuff. I'll try to redo the relevant changes on main in a separate PR to reduce diff and make it reviewable. Shouldn't take long.

@majochamajocha closed this Feb 25, 2024
@majocha
majocha deleted the ib-reduce-complexity branch February 25, 2024 10:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants

@majocha@nojaf