Uh oh!
There was an error while loading. Please reload this page.
Collect diagnostics from skipped implementation files, fixes #15337 - #15351
Merged
Conversation
nojaf
reviewed
Jun 9, 2023
Uh oh!
There was an error while loading. Please reload this page.
T-Gro
commented
Jun 9, 2023
Member
cc @0101 for making sure this is covered in your change. |
T-Gro
approved these changes
Jun 9, 2023
0101
commented
Jun 9, 2023
Contributor
Yeah. I should probably hook it into all these tests somehow. |
0101
approved these changes
Jun 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FinalizeTypeCheckTasknow collects all diagnostics, forcing type check of previously skipped implementation files.See #15337