Uh oh!
There was an error while loading. Please reload this page.
Parser: fix while, for, do expression ranges - #15369
Merged
Merged
Conversation
auduchinok
commented
Jun 12, 2023
MemberAuthor
This is ready. Please merge it before #15334, and I'll update that PR. |
abonie
reviewed
Jun 12, 2023
Uh oh!
There was an error while loading. Please reload this page.
abonie
approved these changes
Jun 12, 2023
T-Gro
approved these changes
Jun 13, 2023
T-Gro added a commit
that referenced
this pull request
Apr 15, 2026
- Rename WarnOnLetInSequenceExpression → LetInBodyScoping (no longer a warning) - Move release notes from Added to Fixed, describe parser behavior change - Fix AnonModule range in pars.fsy: use last declaration's Range.End instead of rhs (which includes OBLOCKEND at EOF position). This is the same pattern as PR #12585/#15369 for fixing block-end-derived ranges. Fixes the (2,0--3,0) regression to correct (2,0--2,15). - Add LetIn 08 (do block scoping from WarnExpressionTests) - Add LetIn 09 (function body scoping from WarnExpressionTests) - Add LetIn 10 (indentation continuation: c aligns with b, d is separate) - Update 204 anonymous module baselines (all consistent: end at last content character instead of extending to next-line col 0) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro added a commit
that referenced
this pull request
Apr 20, 2026
- Rename WarnOnLetInSequenceExpression → LetInBodyScoping (no longer a warning) - Move release notes from Added to Fixed, describe parser behavior change - Fix AnonModule range in pars.fsy: use last declaration's Range.End instead of rhs (which includes OBLOCKEND at EOF position). This is the same pattern as PR #12585/#15369 for fixing block-end-derived ranges. Fixes the (2,0--3,0) regression to correct (2,0--2,15). - Add LetIn 08 (do block scoping from WarnExpressionTests) - Add LetIn 09 (function body scoping from WarnExpressionTests) - Add LetIn 10 (indentation continuation: c aligns with b, d is separate) - Update 204 anonymous module baselines (all consistent: end at last content character instead of extending to next-line col 0) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro added a commit
that referenced
this pull request
Apr 21, 2026
- Rename WarnOnLetInSequenceExpression → LetInBodyScoping (no longer a warning) - Move release notes from Added to Fixed, describe parser behavior change - Fix AnonModule range in pars.fsy: use last declaration's Range.End instead of rhs (which includes OBLOCKEND at EOF position). This is the same pattern as PR #12585/#15369 for fixing block-end-derived ranges. Fixes the (2,0--3,0) regression to correct (2,0--2,15). - Add LetIn 08 (do block scoping from WarnExpressionTests) - Add LetIn 09 (function body scoping from WarnExpressionTests) - Add LetIn 10 (indentation continuation: c aligns with b, d is separate) - Update 204 anonymous module baselines (all consistent: end at last content character instead of extending to next-line col 0) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the tokens inserted by
LexFilterhave unexpected ranges. Consider this case:There's a
ODECLENDtoken inserted at the()range, to mark an end of thewhileexpression. Using this range allows showing an error in a better place during recovery, but it makes impossible to know where thewhileactually ends when there's an error inside it or an explicitdonekeyword is used:This PR adds original/fallback ranges to some of the
end-like tokens, so they can be used in parser for calculating the correct ranges of the produced nodes. In this PR only some rules withODECLENDactually use them, but it makes sense to also update similar cases in other PRs where needed when improving recovery/ranges there later.It also normalizes ranges of the inner expression nodes produced during recovery.