Skip to content

Parser: recover on unfinished nested modules - #15402

Merged
vzarytovskii merged 3 commits into
dotnet:mainfrom
auduchinok:parser-nestedModule
Jun 19, 2023
Merged

Parser: recover on unfinished nested modules#15402
vzarytovskii merged 3 commits into
dotnet:mainfrom
auduchinok:parser-nestedModule

Conversation

@auduchinok

@auduchinokauduchinok commented Jun 15, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Various unfinished nested module cases:

namespaceNs
module
namespaceNsmodulerec
namespaceNsmoduleA
namespaceNsmoduleA =

Recovery for subsequent declarations is possible due to the new rules:

namespaceNsmoduleA =moduleB =()

@auduchinok
auduchinok requested a review from a team as a code ownerJune 15, 2023 10:31
T-Gro
T-Gro reviewed Jun 15, 2023
View reviewed changes
Comment threadsrc/Compiler/pars.fsy Outdated
T-Gro
T-Gro reviewed Jun 15, 2023
View reviewed changes
Comment threadsrc/Compiler/SyntaxTree/LexFilter.fs Outdated
@auduchinok
auduchinokforce-pushed the parser-nestedModule branch 2 times, most recently from 54666eb to ccb781eCompareJune 15, 2023 15:46
@auduchinok

auduchinok commented Jun 15, 2023

Copy link
Copy Markdown
MemberAuthor

This is ready.

@auduchinok
auduchinok requested a review from T-GroJune 16, 2023 14:48
@vzarytovskii
vzarytovskii merged commit db4dbc1 into dotnet:mainJun 19, 2023
@auduchinok
auduchinok deleted the parser-nestedModule branch June 19, 2023 11:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskiivzarytovskiivzarytovskii approved these changes
@T-GroT-GroT-Gro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@auduchinok@vzarytovskii@T-Gro