Update error message of parsMultipleAccessibilitiesForGetSet

[nojaf]

Fixes#15423

[vzarytovskii]

I don't think that's right.
Private setter, public getter scenario is very common one. Or am I missing something (looking from my phone)?

[T-Gro]

Please see the comment here #15423 (comment) .

The error is only in case of mixing "outer" and "inner" declaration of visibility for a property.
Getter and setter can have different accessibilities just fine.

[KevinRansom]

@nojaf - I believe this is not the correct fix.

typeFoo()=memberf.Xwithinternal get (key1, key2)=trueandprivateset(key1,key2)value =()memberinternalf.Ywith get (key1,key2)=trueandprivateset(key1,key2)value =()

If you do not specify the visibility of the property F# allows you specify individual visibilities for the getter and setter, as shown in the X property of the repro.

The reason F# needs this behaviour is for C# interop which also allows, distinct visibilities for the getter or setter,
E.g.

publicstringShowSomething{set;privateget;}="Some text value";

The Y property has an error because if you specify the visibility of the property, then you are not allowed to specify the visibility of the getters and setters.

I think improving the error message would have been better. Something like, "When the visibility for a property is specified, setting the visibility of the set or get method is not allowed."

[nojaf]

Thanks everyone, I was indeed confused about all of this.
I've updated the error message as @KevinRansom suggested.