Skip to content

Print two members in signature file when the visibility differs between the getter and setter. - #15435

Merged
psfinaki merged 3 commits into
dotnet:mainfrom
nojaf:setter-in-signatures
Jun 19, 2023
Merged

Print two members in signature file when the visibility differs between the getter and setter.#15435
psfinaki merged 3 commits into
dotnet:mainfrom
nojaf:setter-in-signatures

Conversation

@nojaf

@nojafnojaf commented Jun 19, 2023

Copy link
Copy Markdown
Contributor

Before:
image

After:
image

@nojaf
nojaf marked this pull request as ready for review June 19, 2023 10:57
@nojaf
nojaf requested a review from a team as a code ownerJune 19, 2023 10:57
psfinaki
psfinaki approved these changes Jun 19, 2023
View reviewed changes
Comment threadsrc/Compiler/Checking/NicePrint.fs
psfinaki
psfinaki approved these changes Jun 19, 2023
View reviewed changes
Comment threadsrc/Compiler/Checking/NicePrint.fs
@psfinaki
psfinaki merged commit fd05137 into dotnet:mainJun 19, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-GroT-GroT-Gro approved these changes
+1 more reviewer
@psfinakipsfinakipsfinaki approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nojaf@psfinaki@T-Gro