Skip to content

Parser: recover on unfinished namespaces and top level modules - #15439

Merged
psfinaki merged 2 commits into
dotnet:mainfrom
auduchinok:parser-namespace
Jun 20, 2023
Merged

Parser: recover on unfinished namespaces and top level modules#15439
psfinaki merged 2 commits into
dotnet:mainfrom
auduchinok:parser-namespace

Conversation

@auduchinok

@auduchinokauduchinok commented Jun 19, 2023

Copy link
Copy Markdown
Member

Add recovery for various namespaces and top level modules:

namespace
namespaceNs2
module
namespacerec
namespace
()

@auduchinok
auduchinok requested a review from a team as a code ownerJune 19, 2023 18:56
psfinaki
psfinaki approved these changes Jun 20, 2023
View reviewed changes

@psfinakipsfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :)

@psfinaki
psfinaki merged commit 325d6f4 into dotnet:mainJun 20, 2023
@auduchinok
auduchinok deleted the parser-namespace branch June 20, 2023 10:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-GroT-GroT-Gro approved these changes
+1 more reviewer
@psfinakipsfinakipsfinaki approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@auduchinok@psfinaki@T-Gro