Skip to content

Implement completions for union case field names in patterns - #15745

Merged
psfinaki merged 13 commits into
dotnet:mainfrom
kerams:f
Aug 16, 2023
Merged

Implement completions for union case field names in patterns#15745
psfinaki merged 13 commits into
dotnet:mainfrom
kerams:f

Conversation

@kerams

Copy link
Copy Markdown
Contributor

devenv_3LbH2w0jKa

Unfortunately, VS does its own sorting, so when these items are not the only thing on the list, they might be buried deep.

devenv_a67wgbdqL3

@kerams
kerams requested a review from a team as a code ownerAugust 3, 2023 16:17
@keramskerams changed the title Implement completions for union case fields in patternsImplement completions for union case field names in patternsAug 3, 2023
@kerams
kerams marked this pull request as draft August 4, 2023 16:25
@kerams

Copy link
Copy Markdown
ContributorAuthor

#15754 needs to go first.

@kerams
kerams marked this pull request as ready for review August 8, 2023 16:19
@kerams

Copy link
Copy Markdown
ContributorAuthor

I had to fix the range of SynPat.LongIndent when it takes named pat pairs and there's a redundant semicolon at the end - the range stops at the semicolon instead of the rparen. The parsing code around atomicPatsOrNamePatPairs is ever so slightly simpler now.

cc @auduchinok

Comment threadsrc/Compiler/pars.fsy
@kerams

Copy link
Copy Markdown
ContributorAuthor

The CI is gunted. Otherwise ready.

@vzarytovskii
vzarytovskii enabled auto-merge (squash) August 16, 2023 09:28
@vzarytovskii

Copy link
Copy Markdown
Member

@dotnet/fsharp-team-msft can I get a second approval pls?

Comment threadsrc/Compiler/Service/FSharpCheckerResults.fs Outdated
Comment threadsrc/Compiler/Service/FSharpCheckerResults.fs
auto-merge was automatically disabled August 16, 2023 13:25

Head branch was pushed to by a user without write access

@psfinaki
psfinaki enabled auto-merge (squash) August 16, 2023 13:59
@psfinaki
psfinaki merged commit c9ad8e3 into dotnet:mainAug 16, 2023
@kerams
kerams deleted the f branch August 16, 2023 14:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants

@kerams@vzarytovskii@auduchinok@psfinaki