Skip to content

Improving AddOpen code fix provider - #15912

Merged
psfinaki merged 5 commits into
dotnet:mainfrom
psfinaki:codefixes-29
Sep 5, 2023
Merged

Improving AddOpen code fix provider#15912
psfinaki merged 5 commits into
dotnet:mainfrom
psfinaki:codefixes-29

Conversation

@psfinaki

@psfinakipsfinaki commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

This addresses some, but not all, problems of the AddOpen code fix.

In particular:

The code is crap but I am keeping most of it for now no minimize the risks.

@psfinaki
psfinaki requested a review from a team as a code ownerSeptember 1, 2023 16:40
psfinaki
psfinaki commented Sep 1, 2023
View reviewed changes
Comment threadvsintegration/src/FSharp.Editor/CodeFixes/AddOpenCodeFixProvider.fs
@psfinaki
psfinaki enabled auto-merge (squash) September 5, 2023 11:59
vzarytovskii
vzarytovskii reviewed Sep 5, 2023
View reviewed changes
Comment threadvsintegration/src/FSharp.Editor/CodeFixes/AddOpenCodeFixProvider.fs Outdated
0101
0101 approved these changes Sep 5, 2023
View reviewed changes

@01010101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid testing!

@psfinaki
psfinaki merged commit 28cb3a3 into dotnet:mainSep 5, 2023
@allisonchouallisonchou mentioned this pull request Sep 7, 2023
Closed
@psfinaki
psfinaki deleted the codefixes-29 branch February 10, 2025 15:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-GroT-GroT-Gro approved these changes
@vzarytovskiivzarytovskiiAwaiting requested review from vzarytovskii
+1 more reviewer
@010101010101 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

4 participants

@psfinaki@0101@vzarytovskii@T-Gro