Skip to content

Parser: recover on unfinished record patterns - #15921

Merged
T-Gro merged 2 commits into
dotnet:mainfrom
auduchinok:parser-recordPat
Sep 5, 2023
Merged

Parser: recover on unfinished record patterns#15921
T-Gro merged 2 commits into
dotnet:mainfrom
auduchinok:parser-recordPat

Conversation

@auduchinok

@auduchinokauduchinok commented Sep 4, 2023

Copy link
Copy Markdown
Member

As discussed in #15903, adds recovery for the following cases:

match()with|{}->()
match()with|{ F }->()
match()with|{ F =}->()

@auduchinok
auduchinok requested a review from a team as a code ownerSeptember 4, 2023 11:24
psfinaki
psfinaki approved these changes Sep 4, 2023
View reviewed changes

@psfinakipsfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beatiful

Comment threadtests/service/data/SyntaxTree/Pattern/SynPatRecordContainsTheRangeOfTheEqualsSign.fs
@psfinakipsfinaki mentioned this pull request Sep 4, 2023
Merged
@T-Gro
T-Gro merged commit f496b3c into dotnet:mainSep 5, 2023
@allisonchouallisonchou mentioned this pull request Sep 7, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-GroT-GroT-Gro approved these changes
+2 more reviewers
@psfinakipsfinakipsfinaki approved these changes
@edgarfgpedgarfgpedgarfgp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@auduchinok@psfinaki@edgarfgp@T-Gro