Skip to content

Remove 'Capture identifiers when parsing' setting from VS options - #15939

Merged
0101 merged 2 commits into
dotnet:mainfrom
0101:remove-capture-identifiers-setting
Oct 5, 2023
Merged

Remove 'Capture identifiers when parsing' setting from VS options#15939
0101 merged 2 commits into
dotnet:mainfrom
0101:remove-capture-identifiers-setting

Conversation

@0101

@01010101 commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

I don't think we should expose this setting. Not sure why we added it to VS options. It's required by Fast find references and doesn't affect anything else, so it doesn't make sense to have it as a separate setting.

@0101
0101 requested a review from a team as a code ownerSeptember 6, 2023 13:20
@vzarytovskii

Copy link
Copy Markdown
Member

I added most of settings we pass to checker for tracing purposes to see how much they impact memory and cpu

@0101
0101 enabled auto-merge (squash) September 13, 2023 11:07
@0101
0101 merged commit 739acb3 into dotnet:mainOct 5, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants

@0101@vzarytovskii@abonie@T-Gro