Skip to content

Symbols: Add GenericArguments to FSharpEntity - #16470

Merged
vzarytovskii merged 4 commits into
dotnet:mainfrom
auduchinok:fsSymbol
Feb 7, 2024
Merged

Symbols: Add GenericArguments to FSharpEntity#16470
vzarytovskii merged 4 commits into
dotnet:mainfrom
auduchinok:fsSymbol

Conversation

@auduchinok

@auduchinokauduchinok commented Dec 27, 2023

Copy link
Copy Markdown
Member

This is a continuation of #16456. It adds a public API for getting type arguments from resolved FSharpEntity items, so type arguments are accessible in cases like this:

int list
IList<int>
T<_>

The new API is not perfectly aligned with a similar one in FSharpSymbolUse, and I'm still thinking about ways to unify them. For now this seems to work good enough, and I'd like to make it available for use in the meanwhile.

@auduchinok
auduchinok requested a review from a team as a code ownerDecember 27, 2023 14:10
@github-actions

github-actionsBot commented Dec 30, 2023

Copy link
Copy Markdown
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/8.0.300.md

@auduchinok

Copy link
Copy Markdown
MemberAuthor

This is ready.

@vzarytovskii
vzarytovskii merged commit 0de949c into dotnet:mainFeb 7, 2024
@auduchinok
auduchinok deleted the fsSymbol branch February 7, 2024 13:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants

@auduchinok@vzarytovskii@edgarfgp@T-Gro