Skip to content

Speed up unused opens handling for empty results - #16502

Merged
psfinaki merged 2 commits into
mainfrom
bench/9
Jan 8, 2024
Merged

Speed up unused opens handling for empty results#16502
psfinaki merged 2 commits into
mainfrom
bench/9

Conversation

@psfinaki

Copy link
Copy Markdown
Contributor

Before:

BenchmarkDotNet=v0.13.2, OS=Windows 11 (10.0.22621.2861)
11th Gen Intel Core i7-1185G7 3.00GHz, 1 CPU, 8 logical and 4 physical cores
.NET SDK=8.0.100
[Host] : .NET 8.0.0 (8.0.23.53103), X64 RyuJIT AVX2 DEBUG
DefaultJob : .NET 8.0.0 (8.0.23.53103), X64 RyuJIT AVX2
MethodMeanErrorStdDevMedianGen0Allocated
UnusedOpens924.6 us41.93 us119.0 us889.5 us11.7188747.91 KB

After:

BenchmarkDotNet=v0.13.2, OS=Windows 11 (10.0.22621.2861)
11th Gen Intel Core i7-1185G7 3.00GHz, 1 CPU, 8 logical and 4 physical cores
.NET SDK=8.0.100
[Host] : .NET 8.0.0 (8.0.23.53103), X64 RyuJIT AVX2 DEBUG
DefaultJob : .NET 8.0.0 (8.0.23.53103), X64 RyuJIT AVX2
MethodMeanErrorStdDevGen0Allocated
UnusedOpens80.31 us1.602 us2.348 us0.610443.21 KB

@psfinaki
psfinaki requested a review from a team as a code ownerJanuary 8, 2024 15:18
@github-actions

github-actionsBot commented Jan 8, 2024

Copy link
Copy Markdown
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/8.0.200.md

@psfinaki
psfinaki enabled auto-merge (squash) January 8, 2024 16:31
0101
0101 approved these changes Jan 8, 2024
@psfinaki
psfinaki merged commit 63cb950 into mainJan 8, 2024
@psfinaki
psfinaki deleted the bench/9 branch January 8, 2024 18:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants

@psfinaki@0101@abonie